perf(remix-dev/vite): use structuredClone instead of JSON.parse(JSON.stringify())
#9968
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 36a7de8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳 |
MichaelDeBoey
changed the title
structuredClone instead of JSON.parse(JSON.stringify())
MichaelDeBoey
requested changes
Sep 10, 2024
xSyki
force-pushed
the
clone-manifest
branch
from
2d0dec7 to
6351936
Compare
|
@MichaelDeBoey Thanks for review, fixed |
MichaelDeBoey
approved these changes
Sep 15, 2024
|
@MichaelDeBoey Thanks for approve |
|
@MichaelDeBoey Can we merge that one? |
MichaelDeBoey
requested review from
machour,
markdalgleish,
brophdawg11 and
brookslybrand
brophdawg11
reviewed
Sep 30, 2024
brophdawg11
requested review from
pcattori and
brophdawg11
and removed request for
machour,
brophdawg11 and
brookslybrand
|
@brophdawg11 I changed it to what you suggested |
MichaelDeBoey
approved these changes
Oct 7, 2024
MichaelDeBoey
force-pushed
the
clone-manifest
branch
from
081b287 to
36a7de8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON.parse(JSON.stringify(is not a recommended method for doing deepCopy. I suggest changing it to native structuredClonehttps://developer.mozilla.org/en-US/docs/Web/API/structuredClone
https://web.dev/articles/structured-clone
Benchmarks
https://jsperf.app/watawu
Support
https://caniuse.com/?search=structuredClone
Testing Strategy:
Called function directly