Ensure that label names in processor start with capital letter #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change is needed since even if ANTLR enables to have lower-case label names, but it will convert them to start with capital letter eventually, since the Context class created from them must be capital. Since the name of this Context class will be used by grammarinator-parse to create nodes from labelled rules, we need to ensure a common naming schema.
akosthekiss
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change is needed since even if ANTLR enables to have lower-case label names, but it will convert them to start with capital letter eventually, since the Context class created from them must be capital. Since the name of this Context class will be used by grammarinator-parse to create nodes from labelled rules, we need to ensure a common naming schema.