collector: skb: handle VLAN in the payload #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collecting packets with one or more VLAN header(s) in their payload resulted in packets we could not parse. Fix this by skipping the VLAN headers if we found them. The VLAN information is reported in the event but is coming from the BPF part directly (to support h/w acceleration). Signed-off-by: Antoine Tenart <[email protected]>
atenart
force-pushed
the
at/vlan-payload
branch
from
f6cc21c to
9a7c8eb
Compare
|
Note that this does not address some remaining questions about VLAN support (how to report and properly handle QinQ mainly), they will be handled separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collecting packets with one or more VLAN header(s) in their payload resulted in packets we could not parse. Fix this by skipping the VLAN headers if found. The VLAN information is reported in the event but is coming from the BPF part directly (to support h/w acceleration).