fix: propagate fetcher errors back to the user

reubenmiller · Jan 22, 2025 · d13fc64 · d13fc64
1 parent af1c9b7
commit d13fc64
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/pkg/c8yfetcher/c8yfetcher.go b/pkg/c8yfetcher/c8yfetcher.go
@@ -130,8 +130,10 @@ func lookupEntity(fetch EntityFetcher, values []string, getID bool, format strin
 						Data: resultSet,
 					})
 				}
+			} else {
+				// Propagate errors back to the caller
+				return entities, err
 			}
-			// TODO: Handle error
 		} else {
 			entities = append(entities, entityReference{
 				ID: applyFormatter(id, format),
@@ -150,8 +152,10 @@ func lookupEntity(fetch EntityFetcher, values []string, getID bool, format strin
 					Data: resultSet,
 				})
 			}
+		} else {
+			// Propagate errors back to the caller
+			return entities, err
 		}
-		// TODO: Handle error
 	}
 
 	return entities, nil

diff --git a/pkg/mapbuilder/mapbuilder.go b/pkg/mapbuilder/mapbuilder.go
@@ -1060,10 +1060,8 @@ func (b *MapBuilder) MarshalJSONObject() (body []byte, err error) {
 		Logger.Debugf("body iterator. path=%s, value=%s", it.Path, value)
 
 		if itErr != nil {
-			if itErr == io.EOF {
-				err = itErr
-				return
-			}
+			err = itErr
+			return
 		} else {
 			switch extInput := input.(type) {
 			case []byte: