Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of figure to data.rmd vignette (issue #12) #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Addition of figure to data.rmd vignette (issue #12) #45

wants to merge 1 commit into from

Conversation

superjai
Copy link
Contributor

@superjai superjai commented Dec 3, 2020

Hi @richfitz - here is a figure for the other vignette. What do you think?

@codecov-io
Copy link

Codecov Report

Merging #45 (34bbd6e) into master (dbb04d8) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #45   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          680       680           
=========================================
  Hits           680       680           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dbb04d8...34bbd6e. Read the comment docs.

@richfitz richfitz self-requested a review December 3, 2020 10:11
@superjai
Copy link
Contributor Author

Hi @richfitz - I was just wondering if you had any thoughts on the figure I created for your vignette. Thanks!

@richfitz
Copy link
Member

Hi @superjai - thanks for this and for the prompt. I have had, but need to get the time to review properly as I think they need some work. Unfortunately I've been snowed under recently so have not managed to get the time to do so but will look as soon as I can 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants