feat!: change default value for riem_measures(latlon)
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
still need to fix the tests |
|
@JElchison feedback welcome 😸 |
JElchison
reviewed
Jan 21, 2025
| * New arguments `data`, `latlon`, `report_type`, `elev` (#49, @JElchison). | ||
| * New arguments `data`, `latlon`, `report_type`, `elev` (#48, @JElchison). | ||
|
|
||
| * Breaking change: `laton` default to `FALSE`: you need to explicitly set it to |
There was a problem hiding this comment.
Minor typo: s/laton/latlon/
JElchison
reviewed
Jan 21, 2025
| @@ -10,8 +10,10 @@ | |||
| #' Default value is `all`. | |||
| #' @param elev If TRUE, the elevation (m) of the station will be included in the output, in an `elevation` column. # nolint: line_length_linter | |||
| #' Default value is `FALSE`. | |||
| #' @param latlon If TRUE, the latitude and longitude of the station will be included in the output, in `lat` and `lon` columns. # nolint: line_length_linter | |||
| #' Default value is `TRUE`. | |||
| #' @param latlon Default to `FALSE` since riem 1.0.0. If `TRUE`, | |||
There was a problem hiding this comment.
I saw a tag in the repo history for v2.0.0. Is it safe to assume that tag was actually supposed to be v0.2.0, and this next release will be v1.0.0?
JElchison
reviewed
Jan 21, 2025
| ``` | ||
|
|
||
| # Documentation | ||
|
|
||
| Please refer to the [`pkgdown` website](https://docs.ropensci.org/riem/) to read docs, in particular the [reference](https://docs.ropensci.org/riem/reference/index.html) and the [vignettes](https://docs.ropensci.org/riem/articles/index.html). | ||
|
|
||
| # Breaking change in riem 1.0.0 | ||
|
|
There was a problem hiding this comment.
I believe we should list the other breaking change here as well:
* Breaking change: `date_start` and `station` no longer have default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #50