Workflow for *.pot sync exits if only creation dates were changed #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-blaha
reviewed
Nov 22, 2023
| @@ -38,6 +38,10 @@ jobs: | |||
| git config --global user.name "GitHub Workflow" | |||
| git config --global user.email "[email protected]" | |||
| pushd src | |||
|
|
|||
| # If only creation dates were changed do nothing | |||
| if git diff --ignore-matching-lines='"POT-Creation-Date:' --exit-code; then exit 0; fi | |||
There was a problem hiding this comment.
Here, we check whether there is a change in the source (dnf5) repository.
Wouldn't it be better to verify if the change about to be committed to the weblate repository (dnf5-l10n) is reasonable (contains any other change than the creation date)? I mean to move the test after git -C l10n add "*" line and check the --staged diff (to cover also newly added files).
This way we ensure that after the workflow run, the weblate repo contains correct *.pot files.
There was a problem hiding this comment.
That is better, I have updated it. 👍
Otherwise the dnf5-l10n repo might contain mostly empty commits.
kontura
force-pushed
the
pot_sync_only_on_change
branch
from
5187244 to
ccece43
Compare
Merged
via the queue into
rpm-software-management:main
with commit Nov 22, 2023
d6053a7
5 of 13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise the dnf5-l10n repo might contain mostly empty commits.