Optimize build process: Do not create object files archive library libdnf5_static.a
#2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And removes `common` from the `dnf5daemon-server` dependency. It is not used.
The "libdnf5_static.a" object files archive was not packaged. It was only used in unit tests of the "libdnf5" library. The use of the archive in the "libdnf5" unit tests was intentional. The unit tests call private methods that have hidden symbols not exported by the shared library. Now the `INTERFACE` library is defined instead of the object files archive. It specify usage requirements for dependents but does not produce a library artifact on disk. The "libdnf5" unit tests link directly to the object files without the need for an intermediate archive.
Maybe increasing the minimum CMake version is not necessary, but the CMake documentation states: Referencing `$<TARGET_OBJECTS>` in target_link_libraries calls worked in versions of CMake prior to 3.21 for some cases, but was not fully supported.
jrohel
force-pushed
the
no_create_libdnf5_object_archive
branch
from
f6d2f7f to
ec9cd41
Compare
Conan-Kudo
approved these changes
Jan 14, 2025
Merged
via the queue into
rpm-software-management:main
with commit Jan 14, 2025
df97dfb
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #2003
The "libdnf5_static.a" object files archive was not packaged. It was only used in unit tests of the "libdnf5" library. The use of the archive in the "libdnf5" unit tests was intentional. The unit tests call private methods that have hidden symbols not exported by the shared library.
Now the
INTERFACElibrary is defined instead of the object files archive. It specify usage requirements for dependents but does not produce a library artifact on disk. The "libdnf5" unit tests link directly to the object files without the need for an intermediate archive.