Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argument completion without description, Bash completion "menu complete" #2017

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Argument completion without description, Bash completion "menu complete" #2017

wants to merge 3 commits into from

Conversation

jrohel
Copy link
Contributor

@jrohel jrohel commented Jan 23, 2025

Closes: #1990

  • Added support for suggesting arguments for completion without adding a description in cli:.ArgumentParser
  • Added support for suggesting command line arguments without descriptions in dnf5.
  • Added support for "menu completion" in bash completion.

jrohel added 3 commits January 23, 2025 13:18
@jrohel
cli::ArgumentParser: Support for suggesting args without description
db4766f 
Added methods for setting/getting whether to add a description
to suggested arguments on completion:
void set_complete_add_description(bool enable) noexcept;
bool get_complete_add_description() noexcept;
@jrohel
DNF5: Support for suggesting command line args without description
921d222 
If the argument at position 1 is
`--complete=<index>[,add_description=1/0]`, this is a request
to complete the argument at position `<index>`.

Before, only `--complete=<index>` was used and the following text was
ignored. Now the optional `,add_description=1/0` is recognized, which
enables/disables the addition of a description to the proposed command
line arguments. By default, adding a description is enabled.
@jrohel
DNF5 bash completion: "menu completion" support
dbd5fa3 
"Menu completion" cyclically completes the suggestions from the list.
We don't want to add a description to the added argument -> We need
a list of suggestions without descriptions.

"Normal completion" completes an identical part of the suggestions.
The added description is not printed. -> Descriptions can be
in the suggestion list, but will not be used. We can optimize the code
and not add the descriptions to the list.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bash autocompletion adds command description to completed line
1 participant
@jrohel