Extract unnecessary logic out of the synchronized

[asoto-iov]

Description

Motivation and Context

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• Tests for the changes have been added (for bug fixes / features)
• Requires Activation Code (Hard Fork)

• Other information:

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Manifest Files

[Vovchyk]

@asoto-iov , could you elaborate a bit on why you did those extra changes? Why not just moving that one line outside the synchronized block?

[asoto-iov]

@asoto-iov , could you elaborate a bit on why you did those extra changes? Why not just moving that one line outside the synchronized block?

Just removing the parameter processing out of the synchronized block.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
81.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Vovchyk]

@asoto-iov , could you elaborate a bit on why you did those extra changes? Why not just moving that one line outside the synchronized block?

Just removing the parameter processing out of the synchronized block.

but why wasn't it enough to move one line up to have that param processing outside the block? Did you try to fix anything else besides that? or was it just refactoring attempt?

[Vovchyk]

@asoto-iov , could you elaborate a bit on why you did those extra changes? Why not just moving that one line outside the synchronized block?

Just removing the parameter processing out of the synchronized block.

but why wasn't it enough to move one line up to have that param processing outside the block? Did you try to fix anything else besides that? or was it just refactoring attempt?

LGTM, after discussing this