Fix #392 Auto-Open Bug (#408)

* remove `tabs.onUpdated` event filter (only supported in Firefox) * fix `VideoIDRegEx` pattern to not match embedded URLs
rthaut · Jun 21, 2023 · 24ae92e · 24ae92e
1 parent dbac884
commit 24ae92e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 14 deletions.
diff --git a/app/scripts/background.js b/app/scripts/background.js
@@ -2,7 +2,6 @@ import { OnCommandEventHandler } from "./background/commands";
 import { InitMenus } from "./background/menus";
 import { OpenPopoutBackgroundHelper } from "./background/popout";
 import { OnInstalled, OnRuntimeMessage } from "./background/runtime";
-import { YOUTUBE_VIDEO_URL_PATTERNS } from "./helpers/constants";
 import {
   GetExtraInfoSpec,
   GetFilter,
@@ -42,18 +41,12 @@ browser.webRequest.onSendHeaders.addListener(
   GetExtraInfoSpec("onSendHeaders")
 );
 
-browser.tabs.onUpdated.addListener(
-  async (tabId, changeInfo) => {
-    if (changeInfo.url && IsVideoURL(changeInfo.url, false)) {
-      if (await Options.GetLocalOption("advanced", "autoOpen")) {
-        OpenPopoutBackgroundHelper(changeInfo.url, tabId, false);
-      }
+browser.tabs.onUpdated.addListener(async (tabId, changeInfo) => {
+  if (changeInfo.url && IsVideoURL(changeInfo.url, false)) {
+    if (await Options.GetLocalOption("advanced", "autoOpen")) {
+      OpenPopoutBackgroundHelper(changeInfo.url, tabId, false);
     }
-  },
-  {
-    properties: ["status", "url"],
-    urls: YOUTUBE_VIDEO_URL_PATTERNS,
   }
-);
+});
 
 InitMenus();
diff --git a/app/scripts/helpers/youtube.js b/app/scripts/helpers/youtube.js
@@ -1,7 +1,6 @@
 import { GetParamFromURL } from "./utils";
 
-export const VideoIDRegEx =
-  /(?:(?:v=)|(?:\/embed\/)|(?:\/shorts\/))([^\?\&\/]{11})/;
+export const VideoIDRegEx = /(?:(?:v=)|(?:\/shorts\/))([^\?\&\/]{11})/;
 
 export const VideoLinkOrEmbedRegEx =
   /(?:(?:v=)|(?:\/embed\/)|(?:\/shorts\/)|(?:\/youtu\.be\/))([^\?\&\/]{11})/;