Refactor for RSpec/BeforeAfterAll
#1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darhazer
reviewed
Nov 14, 2023
| @@ -30,11 +30,11 @@ class BeforeAfterAll < Base | |||
| '`use_transactional_fixtures` is enabled, then records created ' \ | |||
| 'in `%<hook>s` are not automatically rolled back.' | |||
|
|
|||
| RESTRICT_ON_SEND = %i[before after].freeze | |||
| RESTRICT_ON_SEND = Set[:before, :after].freeze | |||
There was a problem hiding this comment.
what's the reason to use a set?
Seems that for the majority of cops we use %i. If we prefer set:
- we need to update the rest of the cops
- we can provide a check in the internal investigations that RESTRICT_ON_SEND is defined as Set
There was a problem hiding this comment.
This was to make it easier to reuse in def_node_matcher. If we use %i, it would have to be something like {:#{RESTRICT_ON_SEND.join(' :')}}, wouldn't it?
|
|
||
| # @!method before_or_after_all(node) | ||
| def_node_matcher :before_or_after_all, <<-PATTERN | ||
| $(send _ {:before :after} (sym {:all :context})) | ||
| $(send _ RESTRICT_ON_SEND (sym {:all :context})) |
- Use `Set[...]` instead of %i[...] - Use RESTRICT_ON_SEND in def_node_matcher
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set[...]instead of %i[...]Before submitting the PR make sure the following are checked:
master(if not - rebase it).CHANGELOG.mdif the new code introduces user-observable changes.bundle exec rake) passes (be sure to run this locally, since it may produce updated documentation that you will need to commit).