-
-
Notifications
You must be signed in to change notification settings - Fork 837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
video/external: Bump OpenH264 to 2.5.0 #18581
base: master
Are you sure you want to change the base?
Conversation
Also I think 2.5.0 yields frames later than 2.4.1, will have to investigate further and report upstream... |
@kjarosh @torokati44 issue to update flatpak OpenH264 extension was closed, and it was updated! |
Hi, I am one of the maintainers of the ruffle package in nixpkgs, this version bump would make our package code much cleaner as nixpkgs master has openh264 2.5.0. Thank you. |
There's no multithreaded access to this anyway.
3f2fc7d
to
931010b
Compare
I was thinking of creating a small standalone C program that decodes the frames in the h264 visual test FLV using 2.4.1 and 2.5.0, to use it to file a bug report to OpenH264 about the increased latency... But tiiimeee... 😮💨 |
The raw config and frame data are already available in byte array literal form here: https://bugzilla.mozilla.org/show_bug.cgi?id=1896869 (in the test_standalone.html attachment) |
I suppose we can wait with this until FlatHub also updates
org.freedesktop.Platform.openh264
, so our Flatpak app doesn't regress.Also note that this adds (untested) Windows on ARM64 support!
See for changelog: https://github.com/cisco/openh264/releases/tag/v2.5.0