Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector index support for Memgraph's integration #17570

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

matea16
Copy link
Contributor

@matea16 matea16 commented Jan 21, 2025

Hi! Memgraph recently introduced a vector search feature and I took the opportunity to update the integration with LlamaIndex by adding new capabilities :)

This PR enhances the Memgraph integration with LlamaIndex with several significant improvements and new functionalities:

  1. Support for vector indices
    Added the ability to leverage vector indices in Memgraph using Memgraph's vector search
  2. Optimized schema refresh
    Introduced the SHOW SCHEMA INFO; query to efficiently refresh and synchronize the schema during runtime. This reduces overhead and ensures up-to-date schema information without unnecessary latency.
  3. Bug fixes for parameterized queries

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Your pull-request will likely not be merged unless it is covered by some form of impactful unit testing.

  • I believe this change is already covered by existing unit tests

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 21, 2025
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Collaborator

@logan-markewich logan-markewich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good. Thanks for updating tests.

Out of curiosity, there was a lot of changes to cypher queries. Is this a breaking change for users using the old code?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 21, 2025
@matea16
Copy link
Contributor Author

matea16 commented Jan 22, 2025

Hi @logan-markewich, thank you for being so quick with this! The cypher updates were mostly to improve some functionality, especially with parametrized queries so there shouldn't be any breaking changes, only fixes :)

@logan-markewich logan-markewich merged commit cded84e into run-llama:main Jan 22, 2025
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants