-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): update dependency @react-native-community/datetimepicker to v7.7.0 #23
base: main
Are you sure you want to change the base?
Conversation
package-lock.json
Outdated
"integrity": "sha512-dO1sQy83M/EvnHE2egto05iwXZX7EYn5f/VDMp6afZFRFXRiRo7CzB3VFg4B55gJRJMNBv06NYMLPM3SlpnEGQ==", | ||
"version": "7.4.1", | ||
"resolved": "https://registry.npmjs.org/@react-native-community/datetimepicker/-/datetimepicker-7.4.1.tgz", | ||
"integrity": "sha512-S7KdiWt0VgL93vy8sAlxPtyq8yNTRCNvoVJPkPlKzwuDY1Q5f+E0rsnNvfP0Y/UMhXAUnUo/THGR2qfrsJ9vNg==", | ||
"dev": true, | ||
"dependencies": { | ||
"invariant": "^2.2.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request seems to update the version of "@react-native-community/datetimepicker" from 7.2.0 to 7.4.1. This update looks good, and there don't seem to be any issues with it. However, it's always a good practice to run tests to confirm that everything is working as expected after making such changes. 👍
@@ -28,7 +28,7 @@ | |||
"devDependencies": { | |||
"@babel/core": "^7.20.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.4.1", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request seems to update the version of "@react-native-community/datetimepicker" from 7.2.0 to 7.4.1. This is a minor version update, so it should be safe to merge into the main branch if there are no compatibility concerns.
However, it would be helpful to provide a brief explanation of why this update is necessary or what improvements/bug fixes are expected with the new version. Additionally, it's always good practice to run tests and make sure that the updated dependency doesn't cause any issues with the codebase.
👍 Good job on keeping dependencies up-to-date!
2ec74a4
to
6ae5497
Compare
@@ -28,7 +28,7 @@ | |||
"devDependencies": { | |||
"@babel/core": "^7.20.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.4.1", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request includes an update to the version of "@react-native-community/datetimepicker" to "7.4.1". This seems like a reasonable change, as it may include bug fixes or new features.
However, without more context about the rest of the code, it's difficult to provide specific feedback on how this change might impact the overall application. Consider including more information about how this update fits into the larger picture.
👍 Overall, looks good.
"@react-native-community/datetimepicker@7.4.1": | ||
version "7.4.1" | ||
resolved "https://registry.yarnpkg.com/@react-native-community/datetimepicker/-/datetimepicker-7.4.1.tgz#7fe8c9fc06d36ffbd4860f4e710f6d5ec3fa693d" | ||
integrity sha512-S7KdiWt0VgL93vy8sAlxPtyq8yNTRCNvoVJPkPlKzwuDY1Q5f+E0rsnNvfP0Y/UMhXAUnUo/THGR2qfrsJ9vNg== | ||
dependencies: | ||
invariant "^2.2.4" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the pull request is updating the version of "@react-native-community/datetimepicker" from 7.2.0 to 7.4.1 and there are no other changes in the code. It looks good to me if this is the only change that needs to be made.
6ae5497
to
6c2dce8
Compare
@@ -28,7 +28,7 @@ | |||
"devDependencies": { | |||
"@babel/core": "^7.20.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.4.2", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request appears to be a version upgrade for the "@react-native-community/datetimepicker" dependency. It would be useful to have an explanation or justification for this upgrade in the pull request description. Additionally, it would be good to confirm that the new version is compatible with other dependencies and won't introduce any breaking changes. Overall, the change seems reasonable and safe to merge. 👍
"@react-native-community/datetimepicker@7.4.2": | ||
version "7.4.2" | ||
resolved "https://registry.yarnpkg.com/@react-native-community/datetimepicker/-/datetimepicker-7.4.2.tgz#7f02117fe59926c7430e95839821cf5c6d85b29c" | ||
integrity sha512-+QztrvktEzMEjcmZuyg9yJ4X9i/ly3QBU+SulJeH71X/IxsBRdrEcMRWByYrIpbXhmkk9y+roATUJFT5Z3XwvA== | ||
dependencies: | ||
invariant "^2.2.4" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request updates the version of "@react-native-community/datetimepicker" dependency from 7.2.0 to 7.4.2, which is fine. However, it would be helpful to include a brief explanation in the pull request description about why this update is necessary. Additionally, it's good to double-check whether any other dependencies need to be updated as well, and if there are any associated compatibility concerns. Overall, the code changes look good! 🎉
6c2dce8
to
34222d2
Compare
@@ -28,7 +28,7 @@ | |||
"devDependencies": { | |||
"@babel/core": "^7.20.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.5.0", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes made in the pull request update the version of "@react-native-community/datetimepicker" to "7.5.0". The change looks okay, but it would be good to double-check if there are any breaking changes or new features in the updated version that could affect the functionality of your codebase. Consider running tests and making sure everything works as expected after merging the pull request. 👍
"@react-native-community/datetimepicker@7.5.0": | ||
version "7.5.0" | ||
resolved "https://registry.yarnpkg.com/@react-native-community/datetimepicker/-/datetimepicker-7.5.0.tgz#479143814a9d6373cdb8cd8f90b5cf03ee0e363a" | ||
integrity sha512-nwMje384ib8017P4phJ1v+Y9xkTEGiilV2uoGjFqCNhMFUeBG7kaVy9WKfS1Y0joDlOk4BISm3+3AP4Es5lYZQ== | ||
dependencies: | ||
invariant "^2.2.4" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request updates the version of "@react-native-community/datetimepicker" to 7.5.0. The package is already up-to-date. Therefore, the change proposed by the pull request is not necessary. No further suggestions can be made based on this code snippet. 👍
34222d2
to
80b54b2
Compare
@@ -31,7 +31,7 @@ | |||
"@commitlint/cli": "^17.7.1", | |||
"@commitlint/config-conventional": "^17.7.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.6.0", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request seems to be updating the version of "@react-native-community/datetimepicker" from "7.2.0" to "7.6.0". Without more context, it is difficult to provide any further suggestions for improvement. However, as a general suggestion, it is always good practice to thoroughly test and validate any changes made in a pull request before merging them into the main codebase to avoid potential bugs or issues down the line. 👍
"@react-native-community/datetimepicker@7.6.0": | ||
version "7.6.0" | ||
resolved "https://registry.yarnpkg.com/@react-native-community/datetimepicker/-/datetimepicker-7.6.0.tgz#4de937ee87572fac555e6e641684ddbf532bada1" | ||
integrity sha512-JRQb4bccIWXRV3UWr6ShxtZLhMVHBaV8Fq6fJk0AAysZ35F1U0MdSkRd7eyJWd3JUebsi32j1GK3mdKHoabtrw== | ||
dependencies: | ||
invariant "^2.2.4" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated snippet shows a package version update for "@react-native-community/datetimepicker" from 7.2.0 to 7.6.0, along with its resolved URL and integrity values. The change looks fine, but it might be helpful if you provide more information about the purpose of this specific dependency update. Additionally, it's good practice to include a brief commit message that explains the reasoning behind the update.👍
80b54b2
to
a270c21
Compare
@@ -31,7 +31,7 @@ | |||
"@commitlint/cli": "^17.7.1", | |||
"@commitlint/config-conventional": "^17.7.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.6.1", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request seems to be a package.json file with changes in dependencies. The only change I can see is the version of "@react-native-community/datetimepicker" being updated from 7.2.0 to 7.6.1.
There is no issue with the code, but it's important to ensure that this version update doesn't introduce any compatibility issues or conflicts with other dependencies.
👍 Overall, the changes look good as long as they have been tested thoroughly for compatibility and functionality.
"@react-native-community/datetimepicker@7.6.1": | ||
version "7.6.1" | ||
resolved "https://registry.yarnpkg.com/@react-native-community/datetimepicker/-/datetimepicker-7.6.1.tgz#98bdee01e3df490526ee1125e438c2030becac1f" | ||
integrity sha512-g66Q2Kd9Uw3eRL7kkrTsGhi+eXxNoPDRFYH6z78sZQuYjPkUQgJDDMUYgBmaBsQx/fKMtemPrCj1ulGmyi0OSw== | ||
dependencies: | ||
invariant "^2.2.4" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only difference between the original code and the modified code is the version update of the "@react-native-community/datetimepicker" package from "7.2.0" to "7.6.1". It seems like a valid upgrade, but it is important to check if any other dependencies are affected by this change in version. Otherwise, the code looks good. 👍
a270c21
to
478dadb
Compare
478dadb
to
16e087c
Compare
@@ -31,7 +31,7 @@ | |||
"@commitlint/cli": "^17.7.1", | |||
"@commitlint/config-conventional": "^17.7.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.6.3", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change you made from "@react-native-community/datetimepicker": "7.2.0" to "@react-native-community/datetimepicker": "7.6.3" appears to be a version upgrade, which should generally be fine in terms of keeping your dependencies up to date and potentially benefiting from bug fixes or new features. If this new version is compatible with the rest of your project, it seems like a reasonable update. Make sure to test thoroughly after updating to ensure that it doesn't introduce any regressions or compatibility issues.👍
"@react-native-community/datetimepicker@7.6.3": | ||
version "7.6.3" | ||
resolved "https://registry.yarnpkg.com/@react-native-community/datetimepicker/-/datetimepicker-7.6.3.tgz#c6b7b84a3d6a824b55d2710658d86fe64ce12a72" | ||
integrity sha512-Ceb+zWwX67tJKK8gTk6JRRIlU1DqIuwe2kaFwz28s6SKrU8bn/nSSB8/y9B4vic3hb8Z0WTo22807GA1Kg4W7A== | ||
dependencies: | ||
invariant "^2.2.4" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The update to "@react-native-community/datetimepicker" to version 7.6.3 looks good.
ℹ️ Make sure to check if there are any breaking changes or new features in the updated version that might affect your codebase.
🔍 Verify if the "invariant" dependency also needs to be updated to ensure compatibility and optimal performance.
16e087c
to
1025946
Compare
@@ -31,7 +31,7 @@ | |||
"@commitlint/cli": "^17.7.1", | |||
"@commitlint/config-conventional": "^17.7.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.6.4", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔍 Suggestions for the code:
- Verify compatibility: After updating "@react-native-community/datetimepicker" to version "7.6.4," ensure compatibility with other dependencies.
- Check for breaking changes: Confirm if there are any breaking changes or new configurations needed due to the update.
- Update documentation: Make sure to update any relevant project documentation regarding this dependency change.
- Run tests: Execute appropriate tests to validate that the updated datetimepicker functions correctly in your app post-upgrade.
"@react-native-community/datetimepicker@7.6.4": | ||
version "7.6.4" | ||
resolved "https://registry.yarnpkg.com/@react-native-community/datetimepicker/-/datetimepicker-7.6.4.tgz#b11ae425a51234bab36ba88755cd2a430c53e862" | ||
integrity sha512-mbnZ5xYl4d2dkWPumQD2mTbLrvMunxUQdbmu0CriOLn48Hy1dQLilQcFg3SfVynND0ydJXo5CRPyXWvUaVkrLQ== | ||
dependencies: | ||
invariant "^2.2.4" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Looks good, just a minor observation:
ℹ️ Consider updating the change log or documentation to reflect the new version update in @react-native-community/datetimepicker
from 7.2.0 to 7.6.4. It helps maintain clarity and transparency for users of your codebase.
1025946
to
dfe4101
Compare
@@ -31,7 +31,7 @@ | |||
"@commitlint/cli": "^17.7.1", | |||
"@commitlint/config-conventional": "^17.7.0", | |||
"@react-native-async-storage/async-storage": "1.18.2", | |||
"@react-native-community/datetimepicker": "7.2.0", | |||
"@react-native-community/datetimepicker": "7.7.0", | |||
"@react-native-community/slider": "4.4.2", | |||
"@storybook/addon-actions": "^6.5.16", | |||
"@storybook/addon-controls": "^6.5.16", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Good change updating "@react-native-community/datetimepicker" to version "7.7.0"!
Consider checking for any API changes or new features in the latest version to leverage improvements or enhancements. Make sure this update doesn't introduce compatibility issues with other dependencies or your existing codebase.
"@react-native-community/datetimepicker@7.7.0": | ||
version "7.7.0" | ||
resolved "https://registry.yarnpkg.com/@react-native-community/datetimepicker/-/datetimepicker-7.7.0.tgz#0d0162b0434c7b35883f8c5af846f35e23d045ec" | ||
integrity sha512-nYzZy4DQLRFUzKJShWzRleCaebmCJfZ1lIcFmZgMXJoiVuGJNw3OIGHSWmHhPETh3OhP1RO3to882d7WmDIyrA== | ||
dependencies: | ||
invariant "^2.2.4" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 The updated version for "@react-native-community/[email protected]" looks good.
ℹ️ Also, consider revising the nearby text format consistency for clarity.
c0b1b88
to
dfe4101
Compare
This PR contains the following updates:
7.2.0
->7.7.0
Release Notes
react-native-community/datetimepicker (@react-native-community/datetimepicker)
v7.7.0
Compare Source
Features
This release is also available on:
v7.6.4
Compare Source
Bug Fixes
This release is also available on:
v7.6.3
Compare Source
Bug Fixes
This release is also available on:
v7.6.2
Compare Source
Bug Fixes
This release is also available on:
v7.6.1
Compare Source
Bug Fixes
This release is also available on:
v7.6.0
Compare Source
Features
This release is also available on:
v7.5.0
Compare Source
Features
This release is also available on:
v7.4.2
Compare Source
Bug Fixes
This release is also available on:
v7.4.1
Compare Source
Bug Fixes
This release is also available on:
v7.4.0
Compare Source
Features
This release is also available on:
v7.3.0
Compare Source
Features
This release is also available on:
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.