Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[f5log] add missing backport dep #2094

Closed
wants to merge 1 commit into from
Closed

[f5log] add missing backport dep #2094

wants to merge 1 commit into from

Conversation

pacien
Copy link
Contributor

@pacien pacien commented Oct 28, 2023

No description provided.

@pacien
Copy link
Contributor Author

pacien commented Oct 28, 2023

CI still unhappy, for a good reason though.
That dep should be optional.

@pacien pacien closed this Oct 28, 2023
saulpw
saulpw reviewed Oct 28, 2023
View reviewed changes
Copy link
Owner

@saulpw saulpw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @pacien!

anjakefala added a commit that referenced this pull request Oct 30, 2023
@anjakefala
[deps-] make zoneinfo an optional dependency
dd67e97 
Add missing backport dep #2094

Thanks @pacien!
@anjakefala
Copy link
Collaborator

@pacien I addressed it here! dd67e97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saulpw saulpw saulpw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pacien @anjakefala @saulpw