-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[errors-] create Error(s)Sheet only if it is not already open #2671
Conversation
6a32227
to
1bead2e
Compare
Should I use an explicit |
No, let them use the default. |
1bead2e
to
6a70257
Compare
I found a bug with this fix! To reproduce, put Then type a column without numerical values with |
6a70257
to
5a02cdd
Compare
Oops, nice catch. I fixed it by letting |
5a02cdd
to
e52ade2
Compare
Based on feedback by @daviewales I replaced the short-circuiting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, everything works!
Fixes an inconvenience noted by @daviewales as part of #2573: