scheduling: auto-detect scheduling group key rename() method #2628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make_scheduling_group_key_config() is able to create a fully functional scheduling_group_key_config, apart from the rename() method. Provide for that by detecting if the type has a rename() method and if so, create a thunk for it. This is kept optional for backward compatibility.
|
/cc @piodul |
|
Technically speaking, this change is not forwards compatible because somebody might have a scheduling group key with a Other than that, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make_scheduling_group_key_config() is able to create a fully functional scheduling_group_key_config, apart from the rename() method. Provide for that by detecting if the type has a rename() method and if so, create a thunk for it.
This is kept optional for backward compatibility.