Transition from using setup.py to pyproject.toml to specify project metadata #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gsheni
reviewed
Mar 1, 2024
amontanez24
requested changes
Mar 1, 2024
pyproject.toml
Outdated
| "pandas>=1.1.3;python_version<'3.10'", | ||
| "pandas>=1.3.4;python_version>='3.10' and python_version<'3.11'", | ||
| "pandas>=1.5.0;python_version>='3.11'", | ||
| "scikit-learn>=1.1.3,<2;python_version>='3.10'", |
There was a problem hiding this comment.
here we should add appropriate bounds for all the python versions we support
Suggested change
| "scikit-learn>=1.1.3,<2;python_version>='3.10'", | |
| "scikit-learn>=0.24,<2;python_version<'3.10'", | |
| "scikit-learn>=1.1.0,<2;python_version>='3.10' and python_version<'3.11'", | |
| "scikit-learn>=1.1.3,<2;python_version>='3.11'", |
amontanez24
reviewed
Mar 4, 2024
gsheni
reviewed
Mar 4, 2024
R-Palazzo
force-pushed
the
issue-333-pyproject
branch
from
20a11de to
5aac2e1
Compare
gsheni
approved these changes
Mar 5, 2024
gsheni
reviewed
Mar 5, 2024
|
|
||
| [tool.setuptools] | ||
| include-package-data = true | ||
|
|
There was a problem hiding this comment.
One thing I forgot, you'll need this:
Suggested change
| [tool.setuptools.dynamic] | |
| version = {attr = 'ctgan.__version__'} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CU-86azg1hg1
Resolve #333