Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unit Test for #4228 #4631

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Unit Test for #4228 #4631

wants to merge 4 commits into from

Conversation

guedou
Copy link
Member

@guedou guedou commented Jan 4, 2025

This PR adds a unit test for the fix proposed in #4228.

@guedou guedou closed this Jan 4, 2025
@guedou guedou reopened this Jan 4, 2025
@guedou guedou requested a review from gpotter2 January 4, 2025 16:51
@guedou
Copy link
Member Author

guedou commented Jan 4, 2025

@gpotter2 I made a small fix to the initial PR and added a unit test based on @shapaz comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpotter2 gpotter2 Awaiting requested review from gpotter2

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guedou @shapaz