Remove Python Native API #1273
Merged
Remove Python Native API #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MasterSkepticista <[email protected]>
Signed-off-by: MasterSkepticista <[email protected]>
teoparvanov
reviewed
Jan 16, 2025
Signed-off-by: MasterSkepticista <[email protected]>
Signed-off-by: MasterSkepticista <[email protected]>
MasterSkepticista
force-pushed
the
karansh1/remove_native_api
branch
from
82e0a72 to
cbf291a
Compare
This reverts commit 0ca06ba. Signed-off-by: MasterSkepticista <[email protected]>
Signed-off-by: MasterSkepticista <[email protected]>
teoparvanov
approved these changes
Jan 16, 2025
|
@psfoley @kta-intel Good to go? |
psfoley
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Approved. Just as a note - we will need to update the FeTS Challenge code for 2025 to utilize the Workflow API as a consequence of removing this entirely, as it relies on the Python Native API. This should happen within the next two months.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes (for Native API):
pki_wrong_cntest has been non-functional for a long time, it has been removed because of its dependence on native API)Code (
openfl.native) is preserved for the time being, it is used in a few tests as well as deprecated Interactive API code. This will be removed with Interactive API.How to review this PR: It may be overwhelming given this PR is mostly thousands of line deletions, check for items this PR might have missed to remove, may not have updated to reflect in certain documentation pages etc.