Sanitize queried node types version

seek-oss · Jan 15, 2025 · 0efdaf0 · 0efdaf0
1 parent 805ec17
commit 0efdaf0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/src/cli/migrate/nodeVersion/getNode22TypesVersion.ts b/src/cli/migrate/nodeVersion/getNode22TypesVersion.ts
@@ -1,6 +1,6 @@
 import { execSync } from 'child_process';
 
 export const getNode22TypesVersion = (major: number) =>
-  execSync(`npm show @types/node@^${major} version --json | jq '.[-1]'`)
-    .toString()
-    .replace(/"/g, '');
+  execSync(
+    `npm show @types/node@^${major} version --json | jq '.[-1]'`,
+  ).toString();
diff --git a/src/cli/migrate/nodeVersion/index.ts b/src/cli/migrate/nodeVersion/index.ts
@@ -36,11 +36,12 @@ export const getNode22TypeVersion = (
 ): VersionResult => {
   try {
     const version = getNode22TypesVersion(major);
-    if (!version || !/22\.\d+\.\d+/.test(version)) {
+    const versionRegex = /(22\.\d+\.\d+)/;
+    if (!version || !versionRegex.test(version)) {
       throw new Error('No version found');
     }
     return {
-      version,
+      version: version.replace(versionRegex, '$1'),
       err: undefined,
     };
   } catch {