Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add another git submodule for C# called c-sharp-pro #512

Merged
merged 8 commits into from
Sep 20, 2024
Merged

Conversation

mjambon
Copy link
Member

@mjambon mjambon commented Sep 19, 2024

This uses tree_sitter_c_sharp_pro_ prefix in the C functions to avoid conflicts with the other C# parser so they can be linked into the same executable.

Checklist

  • Any new parsing code was already published, integrated, and merged into Semgrep. DO NOT MERGE THIS PR BEFORE THE SEMGREP INTEGRATION WORK WAS COMPLETED.
  • Change has no security implications (otherwise, ping the security team)

@mjambon mjambon requested a review from aryx September 19, 2024 23:30
@mjambon mjambon requested a review from a team as a code owner September 19, 2024 23:30
lang/c-sharp-pro/ConvexHull.cs Outdated Show resolved Hide resolved
lang/language-variants-0.20.6 Show resolved Hide resolved
lang/semgrep-grammars/src/semgrep-c-sharp-pro/grammar.js Outdated Show resolved Hide resolved
@aryx
Copy link
Collaborator

aryx commented Sep 20, 2024

I thought it would have been simpler to use just one tree-sitter-chsarp, and update it here to the latest but update to a more
recent semgrep-c-sharp in pro, but maybe you're right it's simpler to separate them also here.

@aryx
Copy link
Collaborator

aryx commented Sep 20, 2024

especially if you managed to avoid naming conflicts in C.

@aryx
Copy link
Collaborator

aryx commented Sep 20, 2024

cc @yosefAlsuhaibani who might have to do something similar for another language (I don't remember which one).

@mjambon mjambon merged commit dbb53fe into main Sep 20, 2024
2 of 3 checks passed
@mjambon mjambon deleted the martin/csharp-pro branch September 20, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants