update kotlin #516
Merged
update kotlin #516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
blocked on fwcd/tree-sitter-kotlin#156, which will implement what @emjin did in semgrep/tree-sitter-kotlin@1e57b1b upstream |
|
How do you know he is more responsive? |
the repo was updated recently |
|
@brandonspark should we revive this now that fwcd/tree-sitter-kotlin#156 has been merged? |
|
@emjin should be ready now |
emjin
approved these changes
Jan 13, 2025
|
test-language-kotlin - Success |
aryx
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Kotlin grammar.
More than a year ago, we decided to fork the
tree-sitter-kotlinrepo because the maintainers were being unresponsive, and we wanted slightly better parsing behavior. Now, it seems that the repository is being actively maintained, so I think we can safely go back to the regular Kotlin repo. (we also want their changes)Checklist