Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

better prometheus metrics #97

Merged
merged 6 commits into from
Dec 3, 2024
Merged

better prometheus metrics #97

merged 6 commits into from
Dec 3, 2024

Conversation

tpetr
Copy link
Contributor

@tpetr tpetr commented Dec 3, 2024 •
edited
Loading

This PR does 3 things:

  1. migrates from ginprometheus to using the prometheus client directly
  2. surfaces metrics both "externally" (outside the wireguard tunnel, so that users can monitor the broker) and "internally" (inside the wireguard tunnel, so that semgrep can monitor as well). previously, these metrics were internal-only.
  3. Deletes metrics from the relay command, which isn't really used. We can revisit proper metrics for relay in the near future.

@tpetr tpetr requested a review from vivekkhimani December 3, 2024 15:52
@tpetr tpetr merged commit f25a232 into develop Dec 3, 2024
7 checks passed
@tpetr tpetr deleted the tom/metrics2 branch December 3, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vivekkhimani vivekkhimani vivekkhimani approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpetr @vivekkhimani