-
-
Notifications
You must be signed in to change notification settings - Fork 919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KBM-only remapping #1797
base: main
Are you sure you want to change the base?
KBM-only remapping #1797
Conversation
cc784e4
to
6da09ae
Compare
This was my attempt at designing a GUI for this. Since there's so many functions (ability to add up to 3 inputs per output is the most painful one to design), I can't seem to make it take a smaller space. The intended use for this is that the dropdown boxes list down the possible inputs per output (since there can be up to three), and the user can press the corresponding input button, then input up to three keystrokes to fill in each combobox. Design wise this seems to be the only thing I can think of to support the things this program wants to do, but I am unable to code it this way. As such, I'm at least putting the UI file here, and maybe someone else can code in the input saving and such. (saved as txt file, rename to ui to use) |
@rainmakerv3 I think it's worth combining at least the keyboard, since some people can play on laptops or they don't have a controller, it should have been added a long time ago, and as for the graphical interface, we haven't made significant progress in this direction yet, let's leave it for later. |
Yes I agree. My thought is that this would be a good place to leave this for anyone who wants to use it. But like you, I also believe this is good enough to merge in its current state |
@raphaelthegreat I did the easy changes, and I'll do the rest tomorrow. So far I've only one comment on this: |
You can use projections in ranges to simplify it to
|
…ui window Only works if the ctrl f10 debug menu is off
Well I finally resolved everything in the review, hopefully nothing got broken along the way. |
| L2 | Right Button | | ||
| R2 | Left Button, LShift | | ||
| L3 | X | | ||
| R3 | Q / Middle Button | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing a space.
This is a modified version of my remapping PR that only contains the keyboard and mouse part, as this is already complete and has proven to be mostly bug-free, as it has been extensively tested by people using @diegolix29's fork. The controller part is still WIP and is not ready for merging yet, so until that's ready too, I'll just put this out here following @rainmakerv3's advice. The code still has some controller remapping elements left in, but they aren't hooked up to the main input loop. If I left in anything that I shouldn't have, please let me know.