Implement missing opcode V_CVT_PK_I16_I32 #2046
Open
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added definition of V_CVT_PK_U16_U32
Implemented this opcode to help with shadps4-emu/shadps4-game-compatibility#1864
The pr fails on clang format , your error also can be improved using lle discmap module |
squidbus
reviewed
Jan 20, 2025
| const IR::U32 src0{GetSrc(inst.src[0])}; | ||
| const IR::U32 src1{GetSrc(inst.src[1])}; | ||
| //Clamp the underflow then clamp the overflow from the result | ||
| IR::U32 lo = ir.IMax(src0, ir.Imm32(0x8000), true); |
There was a problem hiding this comment.
I assume this is supposed to be -1 in 16-bits. If these are being used as Imm32 values for 32-bit signed max/min, shouldn't they be 32-bit negative values instead? 0x8000 as a 32-bit immediate would just be 32768 instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps with shadps4-emu/shadps4-game-compatibility#1864 where the opcode is missing, This now continues but errors within disc_map.cpp
The game compatability issue will be updated with new details