SEC-526 #118
SEC-526 #118
Conversation
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
from
dfa3dde to
4afa2ae
Compare
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
2 times, most recently
from
121a685 to
3813532
Compare
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
2 times, most recently
from
43124cc to
b1e3a03
Compare
| console.log('Execution Shard Key in receipt does not match the calculated key from transaction data.') | ||
| } | ||
| if (nestedCountersInstance) nestedCountersInstance.countEvent('receipt', 'executionShardKey mismatch') | ||
| executionShardKey = extractedKey |
There was a problem hiding this comment.
I wonder if fallback should be to the key which we received in receipt. Just in case our extraction logic has some flaws. We can discuss with design team.
There was a problem hiding this comment.
Well, I was thinking about the possibility that the incoming execution shard key from the receipt might contain malicious/falsified information. So, we should instead rely on the shard key we have calculated now.
src/Data/ExtractShardKey.ts
Outdated
| return response.accounts | ||
| } | ||
|
|
||
| throw new Error(`Secure account data not found on node ${node.ip}`) |
There was a problem hiding this comment.
can we add some logs here?if there is any error in response from /secure_accounts api, we lose the error message.
There was a problem hiding this comment.
this will not be used anymore. We are going to use a local config file to fetch the secure accounts
| @@ -0,0 +1,32 @@ | |||
| import * as fs from 'fs' | |||
There was a problem hiding this comment.
can this be written as unit test? what's the purpose of the file?
Also, filePath is hardcoded
There was a problem hiding this comment.
There are multiple different unit tests to cover because of different transaction types and the receipt logs are quite large. I thought this was the most efficient way to test out the function by fetching the receipt logs from the archiver. Testing is still incomplete, QA help is needed.
FilePath was just an example. It can be modified to anything you like. I shall keep it generic and add a disclaimer that this needs to be modified.
fix: add extractKeyFromTx function
chore : formatting fixes fix : add correct shardus-net branch
…unction to handle legacy and access list transactions
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
from
5936793 to
4fd2638
Compare
abdulazeem-tk4vr
force-pushed
the
SEC-526
branch
from
540be76 to
ee30fe4
Compare
Linear : https://linear.app/shm/issue/SEC-526/archiver-is-not-checking-list-of-accounts-belonging-to-actual-accounts