-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gold 111: update to use unified fast stable stringify #12
Conversation
GOLD-111 Migrate explorer repo to use unified stringifier and custom revived parser
ISSUE SUMMARY: <<TODO: Replace this with a short summary of the issue.>> ISSUE REPRO STEPS: <HINT: Add steps to list as-needed. If interaction is complex, add screenshots or a Slack screen-capture video (just drag and drop)>
EXPECTED RESULT: <<TODO: Replace this with your expected results.>> PULL REQUESTS: <HINT: If your fix requires changes in multiple repos, add the following info per-repository.> <<TODO: Enter Repository Name>> Pull Request Link: <<TODO: Insert PR-LINK>> GPT Review Link: <<TODO: Insert GPT-Review-Link>> Jenkins Test Link: <<TODO: Insert Jenkins Test Job Link>> ADDITIONAL INSTRUCTIONS: <HINT: Add any additional instructions needed for the assignee. If you have specific requirements for how the task should be implemented or fixed, enter them or link them here.> <<TODO: Insert additional instructions for assignee.>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of changes :
- Porting over to safeStringify and safeParse in the backend
- Using the typeReviver in the client side of the explorer for appropriate parsing using axios interceptors.
The changes look good to me. We can ship this to production.
38a2dfd
No description provided.