Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gold 111: update to use unified fast stable stringify #12

Merged
merged 4 commits into from
Jun 10, 2024
Merged

Conversation

arhamj
Copy link
Contributor

@arhamj arhamj commented Jun 8, 2024

No description provided.

Copy link

linear bot commented Jun 8, 2024

GOLD-111 Migrate explorer repo to use unified stringifier and custom revived parser

ISSUE SUMMARY:

<<TODO: Replace this with a short summary of the issue.>>


ISSUE REPRO STEPS:

<HINT: Add steps to list as-needed. If interaction is complex, add screenshots or a Slack screen-capture video (just drag and drop)>

  1. <<TODO: Replace with repro step Bump the npm_and_yarn group across 1 directory with 8 updates #1>>
  2. <<TODO: Replace with repro step Bump the npm_and_yarn group across 1 directory with 9 updates #2>>
  3. Observe <<TODO: Describe unintended behavior.>>

EXPECTED RESULT:

<<TODO: Replace this with your expected results.>>


PULL REQUESTS:

<HINT: If your fix requires changes in multiple repos, add the following info per-repository.>

<<TODO: Enter Repository Name>>

Pull Request Link: <<TODO: Insert PR-LINK>>

GPT Review Link: <<TODO: Insert GPT-Review-Link>>

Jenkins Test Link: <<TODO: Insert Jenkins Test Job Link>>


ADDITIONAL INSTRUCTIONS:

<HINT: Add any additional instructions needed for the assignee. If you have specific requirements for how the task should be implemented or fixed, enter them or link them here.>

<<TODO: Insert additional instructions for assignee.>>

S0naliThakur
S0naliThakur previously approved these changes Jun 10, 2024
Copy link
Member

@S0naliThakur S0naliThakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdulazeem-tk4vr abdulazeem-tk4vr self-requested a review June 10, 2024 07:57
Copy link
Member

@abdulazeem-tk4vr abdulazeem-tk4vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of changes :

  • Porting over to safeStringify and safeParse in the backend
  • Using the typeReviver in the client side of the explorer for appropriate parsing using axios interceptors.

The changes look good to me. We can ship this to production.

src/frontend/api/axios.ts Outdated Show resolved Hide resolved
@arhamj arhamj dismissed stale reviews from abdulazeem-tk4vr and S0naliThakur via 38a2dfd June 10, 2024 10:41
@arhamj arhamj merged commit a2642ac into dev Jun 10, 2024
2 checks passed
@mhanson-github mhanson-github deleted the GOLD-111 branch August 30, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants