Don't use stack static stack memory for the client ID. async-mqtt-cli…

…ent doesn't make a copy.
sidoh · Mar 25, 2020 · 089597a · 089597a
1 parent 36c3197
commit 089597a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/lib/MQTT/MqttClient.cpp b/lib/MQTT/MqttClient.cpp
@@ -77,10 +77,9 @@ void MqttClient::begin() {
   mqttClient.setKeepAlive(60);
 
   // Configure client
-  char nameBuffer[30];
-  sprintf_P(nameBuffer, PSTR("epaper-display-%u"), ESP_CHIP_ID());
+  sprintf_P(this->clientName, PSTR("epaper-display-%u"), ESP_CHIP_ID());
+  mqttClient.setClientId(this->clientName);
 
-  mqttClient.setClientId(nameBuffer);
   if (this->username.length() > 0) {
     mqttClient.setCredentials(this->username.c_str(), this->password.c_str());
   }

diff --git a/lib/MQTT/MqttClient.h b/lib/MQTT/MqttClient.h
@@ -42,6 +42,7 @@ class MqttClient {
   String domain;
   String username;
   String password;
+  char clientName[30];
 
   unsigned long lastConnectAttempt;
   TVariableUpdateFn variableUpdateCallback;