Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Less general Exception in sync_model #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Less general Exception in sync_model #32

wants to merge 1 commit into from

Conversation

nikosavola
Copy link
Contributor

Changes one Exception to catch only the expected errors

@HelgeGehring
Copy link
Collaborator

I somehow don't like to just continue on an exception. I less not like doing this for fewer exceptions, but still, I'd guess we should really discuss if there's another option than just ignoring an exception

@nikosavola
Copy link
Contributor Author

I somehow don't like to just continue on an exception. I less not like doing this for fewer exceptions, but still, I'd guess we should really discuss if there's another option than just ignoring an exception

Yeah, just preprocessing the loop or an if check could work as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikosavola @HelgeGehring