Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Change manylinux version for sdist&wheels CI (C++ 20) #3351

Merged
merged 4 commits into from
Nov 20, 2024
Merged

[ci] Change manylinux version for sdist&wheels CI (C++ 20) #3351

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
89b66dc
Switch from manylinux2014 to manylinux_2_28
XanthosXanthopoulos Nov 20, 2024
649b34b
Change CIBW_MANYLINUX_X86_64_IMAGE
XanthosXanthopoulos Nov 20, 2024
24704c1
Set gcc version
XanthosXanthopoulos Nov 20, 2024
92a7918
display installed toolsets [skip ci]
XanthosXanthopoulos Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions .github/workflows/python-packaging.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ jobs:
include:
- cibw_build: manylinux_x86_64
os: ubuntu-24.04
wheel-name: manylinux2014
wheel-name: manylinux_2_28
- cibw_build: macosx_x86_64
os: macos-latest
cibw_archs_macos: x86_64
Expand Down Expand Up @@ -97,12 +97,19 @@ jobs:
env:
CIBW_BUILD: ${{ matrix.cibw_build }}
CIBW_BUILD_VERBOSITY: 1
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
CIBW_BEFORE_BUILD_LINUX: yum -y remove gcc-toolset-12\*; yum -y install gcc-toolset-13; bash -x -c 'rm -rf tiledbsoma*/dist_links/dist/lib*'
# ^ Delete lib folder that apis/python/setup.py:find_or_build() looks for in deciding to
# run CMake build or not. Otherwise it'll keep reusing the library file built in the
# first iteration of cibuildwheel's outer loop, resulting in wheels with the library
# built for the wrong python version.
CIBW_BEFORE_BUILD: bash -x -c 'rm -rf tiledbsoma*/dist_links/dist/lib*'
# ^ Delete lib folder that apis/python/setup.py:find_or_build() looks for in deciding to
# run CMake build or not. Otherwise it'll keep reusing the library file built in the
# first iteration of cibuildwheel's outer loop, resulting in wheels with the library
# built for the wrong python version.
CIBW_ARCHS_MACOS: ${{ matrix.cibw_archs_macos }}
CIBW_ENVIRONMENT_LINUX : CC=/opt/rh/gcc-toolset-13/root/usr/bin/gcc CXX=/opt/rh/gcc-toolset-13/root/usr/bin/g++
CIBW_TEST_SKIP: "*_arm64"
CMAKE_OSX_ARCHITECTURES: ${{ matrix.cibw_archs_macos }}
MACOSX_DEPLOYMENT_TARGET: "11.0"
Expand All @@ -127,17 +134,17 @@ jobs:
- undotted-version: '312'
dotted-version: '3.12'
wheel-name:
- manylinux2014
- manylinux_2_28
- macos-x86_64
- macos-arm64
include:
- wheel-name: manylinux2014
- wheel-name: manylinux_2_28
os: ubuntu-24.04
arch: x86_64
cc: gcc-13
cxx: g++-13
- wheel-name: macos-x86_64
os: macos-latest
os: macos-13
arch: x86_64
cc: clang
cxx: clang++
Expand Down
Loading