Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove database from table on delete with join #74

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

jtomlinson
Copy link
Contributor

SingleStore does not seem to support "DELETE database.table" when a JOIN is present as well. This removes the database when present.

@AdalbertMemSQL AdalbertMemSQL self-requested a review January 2, 2024 09:50
@AdalbertMemSQL
Copy link
Collaborator

Looks good.
I believe that tests are failing because of this issue #76
I also created a ticket to support "DELETE database.table" in SingleStore.

@AdalbertMemSQL AdalbertMemSQL merged commit 1bf7d65 into singlestore-labs:main Jan 2, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants