Several TCP fixes, improvements. #1025
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Dirbaio
commented
Dec 30, 2024
Dirbaio
commented
- tcp: set ack_all when remote acks bytes sent in earlier retransmissions.
- tcp/tests: make sure line number in recv_nothing points to the test code.
- tcp: start retransmit on first data sent, fix FIN retransmit in CLOSING.
- tcp: add zero window probe support.
- RFC 6298 says we should start the retransmit timer as soon as we send a segment that has data. We were starting it on the *last* segment instead. - Simplified logic with set_for_idle, it's now uniform across all tcp states. - Fix FIN retransmits not being sent in CLOSED state.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1025 +/- ##
==========================================
+ Coverage 80.88% 81.21% +0.33%
==========================================
Files 81 81
Lines 28447 28916 +469
==========================================
+ Hits 23010 23485 +475
+ Misses 5437 5431 -6 ☔ View full report in Codecov by Sentry. |
Dirbaio
force-pushed
the
tcp-more-fixes
branch
from
df80c1b to
7a248ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.