Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix orchestration selection logic and add Workflow prompt category #2151

Merged
merged 3 commits into from
Jan 23, 2025
+12 −9
Merged

Fix orchestration selection logic and add Workflow prompt category #2151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
912633a
Fix null checking logic
joelhulen Jan 23, 2025
566b680
Add workflow category
joelhulen Jan 23, 2025
ddea9ba
Rename prompt sidebar item name
joelhulen Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/dotnet/Common/Models/ResourceProviders/Prompt/PromptCategory.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@ public enum PromptCategory
/// </summary>
Agent,

/// <summary>
/// Workflow prompt.
/// </summary>
Workflow,

/// <summary>
/// Tool prompt.
/// </summary>
Expand Down
8 changes: 3 additions & 5 deletions src/dotnet/Orchestration/Orchestration/OrchestrationBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,11 +92,9 @@ public class OrchestrationBuilder

if (result.Agent.AgentType == typeof(KnowledgeManagementAgent))
{
var orchestrator = string.IsNullOrWhiteSpace(
result.Agent.Workflow?.WorkflowHost
?? result.Agent.OrchestrationSettings?.Orchestrator) // TODO: Remove this fallback path after all agents are upgraded.
? LLMOrchestrationServiceNames.LangChain
: result.Agent.OrchestrationSettings?.Orchestrator;
var orchestrator = !string.IsNullOrWhiteSpace(result.Agent.Workflow?.WorkflowHost)
? result.Agent.Workflow.WorkflowHost
: result.Agent.OrchestrationSettings?.Orchestrator ?? LLMOrchestrationServiceNames.LangChain;

if (originalRequest.LongRunningOperation)
{
Expand Down
2 changes: 1 addition & 1 deletion src/ui/ManagementPortal/components/Sidebar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<li><NuxtLink to="/agents/create" class="sidebar__item">Create New Agent</NuxtLink></li>
<li><NuxtLink to="/agents/public" class="sidebar__item">All Agents</NuxtLink></li>
<li><NuxtLink to="/agents/private" class="sidebar__item">My Agents</NuxtLink></li>
<li><NuxtLink to="/prompts" class="sidebar__item">Agent Prompts</NuxtLink></li>
<li><NuxtLink to="/prompts" class="sidebar__item">Prompts</NuxtLink></li>
</ul>
<!-- <div class="sidebar__item">Performance</div> -->

Expand Down
2 changes: 1 addition & 1 deletion src/ui/ManagementPortal/pages/agents/create.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1666,7 +1666,7 @@ export default {
description: `System prompt for the ${this.agentName} agent`,
prefix: this.systemPrompt,
suffix: '',
category: 'Agent',
category: 'Workflow',
};

const tokenTextPartitionRequest = {
Expand Down
4 changes: 2 additions & 2 deletions src/ui/ManagementPortal/pages/prompts/create.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@ export default {

categoryOptions: [
{
label: 'Agent',
value: 'Agent',
label: 'Workflow',
value: 'Workflow',
},
{
label: 'Tool',
Expand Down
Loading