Import definitions via xrefs #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cthoyt
changed the title
|
Great! Just note the issue #159 with non-exact InterPro mappings. |
|
@bgyori I just reorganized to have a priority list and make this a bit more flexible |
|
@bgyori this isn't a perfect PR and won't be so easy to re-run until I re-release PyOBO with some fixes (unless you want to install pyobo in the development mdoe), but it gets the job done of adding 424 descriptions (~60% of famplexes). I made a priority list (which you can feel free to change) where interpro is at the bottom - only one entry gets assigned a name that way. But it gets a lot of the job done, so it might be okay to think about merging now. Let me know what you think |
|
I think this is really great, the descriptions all look appropriate! |
bgyori
approved these changes
Mar 12, 2021
|
Closes #168 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a script that pulls in definitions using new (unreleased) pyobo code from (biopragmatics/pyobo#98 - once I fix the mocks in the testing I will merge it). It prioritizes getting the definitions for famplex entries based on their xrefs in the following order: