Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[issue #119] Update fcontext to allow override of built-in types #120

Merged
merged 12 commits into from
Jul 15, 2024
Merged

[issue #119] Update fcontext to allow override of built-in types #120

merged 12 commits into from
Jul 15, 2024

Conversation

ywei2017
Copy link
Contributor

Description

Allow override of of the fcontext of system built-in file specs.

Issues Resolved

Issue #119

Check List

  • [N/A] A summary of changes made is included in the CHANGELOG under ## Unreleased
  • [Will do once the approach is reviewed] New functionality includes testing.
  • [N/A] New functionality has been documented in the README if applicable.

@ywei2017 ywei2017 requested a review from a team as a code owner April 23, 2024 22:51
@ywei2017 ywei2017 mentioned this pull request Apr 23, 2024
Open
@ywei2017
Copy link
Contributor Author

See testing, for 3 of the instances, I am having issue with the driver. All others tested fine.

@Stromweld Stromweld added Feature Request Enhancement to existing functionality or new functionality Release: Minor Release to Chef Supermarket as a minor release when merged labels Apr 26, 2024
ywei2017 and others added 2 commits April 29, 2024 10:31
@ywei2017 @Stromweld
Update test/cookbooks/selinux_test/recipes/fcontext.rb
b4b95dc 
Thanks for suggestion, I will re-run the test.

Co-authored-by: Corey Hemminger <[email protected]>
@ywei2017
correct syntax error
2d138a4
@Stromweld
Copy link
Contributor

Can you rebase or merge remote main into your current branch and then fix any failing tests. I just merged new test versions.

@ywei2017
Copy link
Contributor Author

ywei2017 commented May 4, 2024 via email

@ywei2017
Copy link
Contributor Author

ywei2017 commented May 12, 2024 •
edited
Loading

@Stromweld - Completed the testing. I had issues earlier which turned out to be the version of Chef Workstation I was using. I also had to make wait_for_retry longer as the description said, for some of the test cases.

Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-almalinux-8> (0m9.87s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-centos-7> (0m9.57s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-centos-stream-8> (0m10.18s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-debian-10> (0m7.61s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-debian-11> (0m7.48s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-fedora-latest> (0m9.35s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-oracle-7> (0m9.40s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-oracle-8> (0m10.29s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-rockylinux-8> (0m9.69s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-ubuntu-1804> (0m7.29s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-ubuntu-2204> (0m8.58s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 14 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-amazonlinux-2> (0m9.59s).
--
Profile Summary: 3 successful controls, 0 control failures, 0 controls skipped
Test Summary: 13 successful, 0 failures, 0 skipped
       Finished verifying <fcontext-ubuntu-2004> (0m8.42s).

@ywei2017
Copy link
Contributor Author

@Stromweld - Any further actions on my side for the PR? Thanks.

@ywei2017
Copy link
Contributor Author

ywei2017 commented Jun 5, 2024

@Stromweld Anything I need to do before the PR can be merged? Thanks.

@Stromweld
Copy link
Contributor

Sorry for taking so long to get back to you. 1 last thing would be to update the .github/workflows/ci.yml to be similar to this one https://github.com/sous-chefs/php/blob/main/.github/workflows/ci.yml to fix the pipeline tests.

@ywei2017 ywei2017 force-pushed the main branch 3 times, most recently from f133d08 to 908a428 Compare June 7, 2024 20:19
Stromweld
Stromweld requested changes Jun 7, 2024
View reviewed changes
.github/workflows/ci.yml Show resolved Hide resolved
@ywei2017
Copy link
Contributor Author

@Stromweld - Do you have an example to pass the integration testing?

  • I don't think the "doken" driver would work, since enabling SELinux requires a reboot, and containers don't survive reboot. I tried both locally and on github, that keeps on failing.
  • Or I can try the "vagrant" driver, but don't know a VM type to use that has Vagrant and virtualbox installed.
    Thanks

@ywei2017
Copy link
Contributor Author

@Stromweld - Do you have an example to pass the integration testing?

  • I don't think the "doken" driver would work, since enabling SELinux requires a reboot, and containers don't survive reboot. I tried both locally and on github, that keeps on failing.
  • Or I can try the "vagrant" driver, but don't know a VM type to use that has Vagrant and virtualbox installed.
    Thanks

@Stromweld Can I get some help here? Sorry to bug you, I am looking for a working example to follow. Thanks.

@Stromweld
Copy link
Contributor

yeah it looks like you are correct on the dokken images. Github Actions runners for macos used to come with vagrant and virtualbox and docker preinstalled. They don't anymore so it's best to switch it to ubuntu-latest like we did and add a step to install vagrant and virtualbox latest versions like here https://github.com/chef/bento/blob/main/.github/workflows/pkr-bld-virtualbox-x64.yml#L38-L45.

Stromweld added 4 commits July 15, 2024 13:30
@Stromweld
Update OS versions for testing
24bad83 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
testing latest vbox version for ci
df13d8c 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
testing vbox install for ci
7f937f4 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld
testing vbox install for ci
3a104e7 
Signed-off-by: Corey Hemminger <[email protected]>
@Stromweld Stromweld merged commit 3f06103 into sous-chefs:main Jul 15, 2024
75 of 84 checks passed
@kitchen-porter
Copy link
Contributor

Released as: 6.2.0

@ywei2017
Copy link
Contributor Author

ywei2017 commented Jul 18, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stromweld Stromweld Stromweld approved these changes

Assignees
No one assigned
Labels
Feature Request Enhancement to existing functionality or new functionality Release: Minor Release to Chef Supermarket as a minor release when merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ywei2017 @Stromweld @kitchen-porter