General readability/extendability improvements #157
Conversation
- Splitting the Package class into traits to improve readability - Splitting the PackageServiceProvider into individual methods - All test back to green
- Removed duplicate config_path line from the boot configs method in the service provider - Merged the ?string checks into the hasViews & hasInertiaComponents from the previous pull requests. - Composer test reporting green
- Rebasing against master to pull in the recent updates
|
I fully support this PR (as I did the previous one) - this is a good modularisation of the code and makes it easier for people to add further functionality - I have a some ideas I am working on to add e.g. Livewire support and support a range of other ServiceProvider features, but it makes sense for me to base my PR on this one so I don't want to submit it until this one has been merged. |
There was a problem hiding this comment.
- I have no idea why you keep submitting new PRs rather than simply fixing the old ones. PLEASE STOP DOING THIS, as all the history of people like me supporting your PR gets lost. I have no idea why you resubmitted this because it seems to have the same code as Rebased PR #145 from Main #152, and my comments to Rebased PR #145 from Main #152 have NOT been dealt with.
- I have no idea why you force pushed to General readability/extendability improvements #145 or Rebased PR #145 from Main #152 to clear out the changes but PLEASE STOP DOING THIS. If you insist on opening a new replacement then just close the old one.
Here are my comments from #152:
In general I like the modular concepts put forward here, with the following comments:
- I like the use of modular Traits in Package.php; and
- I like the splitting of the code in the PackageServiceProvider.php; however
- I would like to see the PackageServiceProvider.php similarly modularised into Traits (named
processXto match thehasXtrait); and - I see no reason why GenerateMigrationName should be an Action (which are supposed to apply to users) rather than simply being a utility method called by other code.
- I would like to see the Test files themselves moved into matching subdirectories (moving them should all that is needed as they should still run).
|
Thanks for your work on this. I'll merge this in and slightly polish it. |
|
Great - as a heads up I want to add functionality for Livewire (to match Inertia), to fully utilise all the capabilities of the ServiceProvider object, to allow user to override the default directories for every This is already partly written, so you might want to wait before issuing a formal version upgrade. |
This is a followup from pull request #145 which includes the most recent changes from master.