Add option to use deterministic entropy in make_seed #6411
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that electrum does not currently have the option to generate a seed with user-provided entropy. Also, the current source of entropy comes from
os.urandom()
via the python-ecdsa dependency. That project's README explicitly states:While practically speaking this will rarely be an issue, I think it's a useful to be able to supply entropy deterministically so users can eliminate this risk categorically.
My main concern with adding this feature is novices mistakenly using it and providing a very low entropy input without clearly understanding what it does. Is it correct to assume the CLI is generally only used by power-users? In any case, I made the option's description cautionary to guard against this risk.