Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change thousands separator to comma #9358

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Update unit test for comma separator

43c3b64
Select commit
Loading
Failed to load commit list.
Open

Change thousands separator to comma #9358

Update unit test for comma separator
43c3b64
Select commit
Loading
Failed to load commit list.
Cirrus CI / unittests: Tox Python 3.9 failed Dec 13, 2024 in 4m 59s

Task Summary

Instruction tox failed in 04:15

Details

✅ 00:16 clone
✅ 00:02 pip
✅ 00:01 version
✅ 00:01 tag
✅ 00:18 install
✅ 00:01 libsecp_build
❌ 04:15 tox

tests/test_wallet_vertical.py::TestWalletOfflineSigning::test_signing_where_offline_ks_does_not_have_keyorigin_but_psbt_contains_it PASSED [ 97%]
tests/test_wallet_vertical.py::TestWalletCreationChecks::test_duplicate_masterkeys_in_multisig PASSED [ 97%]
tests/test_wallet_vertical.py::TestWalletCreationChecks::test_heterogeneous_xpub_types_in_multisig PASSED [ 97%]
tests/test_wallet_vertical.py::TestWalletHistory_SimpleRandomOrder::test_restoring_old_wallet_txorder1 PASSED [ 97%]
tests/test_wallet_vertical.py::TestWalletHistory_SimpleRandomOrder::test_restoring_old_wallet_txorder2 PASSED [ 97%]
tests/test_wallet_vertical.py::TestWalletHistory_SimpleRandomOrder::test_restoring_old_wallet_txorder3 PASSED [ 98%]
tests/test_wallet_vertical.py::TestWalletHistory_EvilGapLimit::test_restoring_wallet_txorder1 PASSED [ 98%]
tests/test_wallet_vertical.py::TestWalletHistory_DoubleSpend::test_restoring_wallet_with_manual_delete PASSED [ 98%]
tests/test_wallet_vertical.py::TestWalletHistory_DoubleSpend::test_restoring_wallet_without_manual_delete PASSED [ 98%]
tests/test_wallet_vertical.py::TestWalletHistory_HelperFns::test_get_tx_status_feerate_for_local_2of3_multisig_partial_tx PASSED [ 98%]
tests/test_wallet_vertical.py::TestWalletHistory_HelperFns::test_get_tx_status_feerate_for_local_2of3_multisig_signed_tx PASSED [ 98%]
tests/test_wallet_vertical.py::TestImportedWallet::test_importing_and_deleting_addresses PASSED [ 98%]
tests/test_wizard.py::ServerConnectWizardTestCase::test_no_advanced PASSED [ 98%]
tests/test_wizard.py::ServerConnectWizardTestCase::test_proxy PASSED     [ 99%]
tests/test_wizard.py::ServerConnectWizardTestCase::test_proxy_and_server PASSED [ 99%]
tests/test_wizard.py::ServerConnectWizardTestCase::test_server PASSED    [ 99%]
tests/test_wizard.py::WalletWizardTestCase::test_2fa PASSED              [ 99%]
tests/test_wizard.py::WalletWizardTestCase::test_create_standard_wallet_haveseed_bip39 PASSED [ 99%]
tests/test_wizard.py::WalletWizardTestCase::test_create_standard_wallet_haveseed_electrum PASSED [ 99%]
tests/test_wizard.py::WalletWizardTestCase::test_create_standard_wallet_newseed PASSED [ 99%]
tests/test_x509.py::TestX509::test_generalizedtime PASSED                [100%]

=================================== FAILURES ===================================
_______________ TestUtil.test_format_satoshis_add_thousands_sep ________________

self = <tests.test_util.TestUtil testMethod=test_format_satoshis_add_thousands_sep>

    def test_format_satoshis_add_thousands_sep(self):
>       self.assertEqual("178 890 000.", format_satoshis(Decimal(178890000), decimal_point=0, add_thousands_sep=True))
E       AssertionError: '178 890 000.' != '178,890,000.'
E       - 178 890 000.
E       ?    ^   ^
E       + 178,890,000.
E       ?    ^   ^

tests/test_util.py:75: AssertionError
=============================== warnings summary ===============================
.tox/py3/lib/python3.9/site-packages/aiorpcx/websocket.py:30
  /tmp/cirrus-ci-build/.tox/py3/lib/python3.9/site-packages/aiorpcx/websocket.py:30: DeprecationWarning: websockets.client.connect is deprecated
    from websockets.client import connect

.tox/py3/lib/python3.9/site-packages/websockets/legacy/__init__.py:6
  /tmp/cirrus-ci-build/.tox/py3/lib/python3.9/site-packages/websockets/legacy/__init__.py:6: DeprecationWarning: websockets.legacy is deprecated; see https://websockets.readthedocs.io/en/stable/howto/upgrade.html for upgrade instructions
    warnings.warn(  # deprecated in 14.0 - 2024-11-09

.tox/py3/lib/python3.9/site-packages/aiorpcx/websocket.py:31
  /tmp/cirrus-ci-build/.tox/py3/lib/python3.9/site-packages/aiorpcx/websocket.py:31: DeprecationWarning: websockets.server.serve is deprecated
    from websockets.server import serve

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================== short test summary info ============================
FAILED tests/test_util.py::TestUtil::test_format_satoshis_add_thousands_sep
======= 1 failed, 747 passed, 5 skipped, 3 warnings in 228.73s (0:03:48) =======
py3: exit 1 (229.97 seconds) /tmp/cirrus-ci-build> coverage run --source=electrum '--omit=electrum/gui/*,electrum/plugins/*,electrum/scripts/*' -m pytest tests -v pid=772
  py3: FAIL code 1 (254.74=setup[24.77]+cmd[229.97] seconds)
  evaluation failed :( (254.84 seconds)