Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of java.home system property in native image #43517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

big-cir
Copy link

@big-cir big-cir commented Dec 16, 2024

Overview

  1. Provides an explicit null check.
  2. Prevents issues in native image mode.

Related Issues

#43050

@pivotal-cla
Copy link

@big-cir Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 16, 2024
@mhalbritter mhalbritter added the status: waiting-for-feedback We need additional information before we can continue label Dec 17, 2024
@snicoll
Copy link
Member

snicoll commented Dec 26, 2024

@big-cir we can't proceed further and are waiting for you to sign the CLA.

@pivotal-cla
Copy link

@big-cir Thank you for signing the Contributor License Agreement!

@big-cir
Copy link
Author

big-cir commented Dec 26, 2024

@snicoll I apologize for the inconvenience. Last time, the signature was not completed due to a bug

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Dec 26, 2024
@mhalbritter mhalbritter changed the title Refactor System.getProperty("java.home") handling in native image Remove usage of java.home system property in native image Jan 16, 2025
@mhalbritter mhalbritter added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged status: feedback-provided Feedback has been provided labels Jan 16, 2025
@mhalbritter mhalbritter added this to the 3.5.x milestone Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A general enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants