Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backup restore functionality added for different versions #14

Open
wants to merge 42 commits into
base: release-1.1.2
Choose a base branch
from

Conversation

divyanshujainSquareops
Copy link

Introduced the ability for users to back up individual databases or all databases collectively. This functionality leverages Kubernetes jobs for both backup and restoration, with support for specifying S3 dump locations for recovery.
Credential Management Fix: Resolved an issue where database credentials were not being properly stored in the secret manager.

@@ -101,7 +103,7 @@ module "rds-pg" {
publicly_accessible = false
skip_final_snapshot = true
backup_window = "03:00-06:00"
maintenance_window = "Mon:00:00-Mon:03:00"
maintenance_window = "Mon:00:00-Mon:03:00
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add double quotes at the end

serviceAccountName: sa-postgres-restore
containers:
- name: restore-postgresdb
image: divyanshujain11/rds:postgres-backup-restore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@divyanshujainSquareops Why are we not using SquareOps-owned registry to store and use docker images?

serviceAccountName: sa-postgres-backup
containers:
- name: backup-postgresdb
image: divyanshujain11/rds:postgres-backup-restore
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link
Author

@divyanshujainSquareops divyanshujainSquareops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update Readme.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants