Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use separate sonarcloud.yaml #192

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Use separate sonarcloud.yaml #192

merged 1 commit into from
Dec 6, 2023

Conversation

dhaiducek
Copy link

No description provided.

@dhaiducek
Copy link
Author

/hold

@dhaiducek dhaiducek closed this Nov 30, 2023
@dhaiducek dhaiducek reopened this Nov 30, 2023
@dhaiducek dhaiducek force-pushed the remove-publish branch 7 times, most recently from ef90a16 to 859ea33 Compare December 5, 2023 21:55
@dhaiducek
Copy link
Author

/unhold

I've disabled all other actions for now. It looks like there's a change upstream that'd fix the test workflows, but it's not worth pulling it into this PR.

@dhaiducek
Use separate sonarcloud.yaml
a7446c4 
This follows the convention from our other repos.
Also, ignore Gosec failures.

Signed-off-by: Dale Haiducek <[email protected]>
@dhaiducek dhaiducek changed the title Remove publish portions of workflow Use separate sonarcloud.yaml Dec 5, 2023
@yiraeChristineKim
Copy link

yiraeChristineKim commented Dec 6, 2023 •
edited
Loading

I am curious why "check" has only one test(Gosec)?

@dhaiducek
Copy link
Author

I am curious why "check" has only one test(Gosec)?

For now, I'm just trying to get SonarCloud working with security scanning, especially since running the existing test workflow was failing.

@openshift-ci openshift-ci bot added the lgtm label Dec 6, 2023
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaiducek,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 81c2fe2 into stolostron:master Dec 6, 2023
1 check passed
@dhaiducek dhaiducek deleted the remove-publish branch December 6, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yiraeChristineKim yiraeChristineKim yiraeChristineKim approved these changes

@gparvin gparvin Awaiting requested review from gparvin

Assignees

@yiraeChristineKim yiraeChristineKim

Labels
approved dco-signoff: yes lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dhaiducek @yiraeChristineKim