Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init build-push to quay/gatekeeper #202

Closed
wants to merge 1 commit into from
Closed

Init build-push to quay/gatekeeper #202

wants to merge 1 commit into from

Conversation

yiraeChristineKim
Copy link

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

@yiraeChristineKim
Copy link
Author

/override build and push to quay

Copy link

openshift-ci bot commented Mar 28, 2024

@yiraeChristineKim: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • and
  • build
  • push
  • quay
  • to

Only the following failed contexts/checkruns were expected:

  • GoSec Scan
  • Image build and push
  • SonarCloud Code Analysis
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override build and push to quay

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiraeChristineKim
Copy link
Author

/override "build and push to quay"

Copy link

openshift-ci bot commented Mar 28, 2024

@yiraeChristineKim: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • build and push to quay

Only the following failed contexts/checkruns were expected:

  • GoSec Scan
  • Image build and push
  • SonarCloud Code Analysis
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "build and push to quay"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiraeChristineKim
Copy link
Author

/override "Image build and push"

Copy link

openshift-ci bot commented Mar 28, 2024

@yiraeChristineKim: Overrode contexts on behalf of yiraeChristineKim: Image build and push

In response to this:

/override "Image build and push"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiraeChristineKim
Copy link
Author

/override 'Image build and push'

Copy link

openshift-ci bot commented Mar 28, 2024

@yiraeChristineKim: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • 'Image
  • and
  • build
  • push'

Only the following failed contexts/checkruns were expected:

  • GoSec Scan
  • SonarCloud Code Analysis
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override 'Image build and push'

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiraeChristineKim
Copy link
Author

/override "Image build and push"

Copy link

openshift-ci bot commented Mar 28, 2024

@yiraeChristineKim: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • Image build and push

Only the following failed contexts/checkruns were expected:

  • GoSec Scan
  • SonarCloud Code Analysis
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "Image build and push"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiraeChristineKim
Copy link
Author

/override "build and push to quay / Image build and push"

Copy link

openshift-ci bot commented Mar 28, 2024

@yiraeChristineKim: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • build and push to quay / Image build and push

Only the following failed contexts/checkruns were expected:

  • GoSec Scan
  • SonarCloud Code Analysis
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override "build and push to quay / Image build and push"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

@dhaiducek dhaiducek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple nits, but this seems like it'll work 🙂

.github/workflows/build-push-stolostron.yaml Outdated Show resolved Hide resolved
.github/workflows/build-push-stolostron.yaml Outdated Show resolved Hide resolved
name: build and push to quay

on:
workflow_dispatch:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed this the first time. We don't want this workflow to be run on-demand.

Suggested change
workflow_dispatch:

- name: build and push
run: |
REPOSITORY=${{env.REPOSITORY}} VERSION=${{env.VERSION_TAG}} make docker-buildx-release

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trailing whitespace after the newline 🙂

Suggested change

@dhaiducek
Copy link

/override "SonarCloud Code Analysis"

Copy link

openshift-ci bot commented Mar 28, 2024

@dhaiducek: Overrode contexts on behalf of dhaiducek: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: yiraeChristineKim <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Mar 28, 2024
Copy link

openshift-ci bot commented Mar 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhaiducek, yiraeChristineKim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dhaiducek,yiraeChristineKim]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yiraeChristineKim
Copy link
Author

/override "SonarCloud Code Analysis"

Copy link

openshift-ci bot commented Mar 28, 2024

@yiraeChristineKim: Overrode contexts on behalf of yiraeChristineKim: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiraeChristineKim
Copy link
Author

/override "SonarCloud Code Analysis"

Copy link

openshift-ci bot commented Mar 28, 2024

@yiraeChristineKim: Overrode contexts on behalf of yiraeChristineKim: SonarCloud Code Analysis

In response to this:

/override "SonarCloud Code Analysis"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yiraeChristineKim yiraeChristineKim deleted the build-ci branch March 28, 2024 21:19
@yiraeChristineKim yiraeChristineKim restored the build-ci branch March 28, 2024 21:19
@yiraeChristineKim yiraeChristineKim deleted the build-ci branch March 28, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants