Experiment: Monorepo refactor #30247

ndelangen · 2025-01-11T18:14:30Z

What I did

merge code and scripts into a single root dir

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

stories
unit tests
integration tests
end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

Add or update documentation reflecting your changes
If you are deprecating/removing a feature, make sure to update
MIGRATION.MD

Checklist for Maintainers

When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli-storybook/src/sandbox-templates.ts
Make sure this PR contains one of the labels below:
Available labels
- bug: Internal changes that fixes incorrect behavior.
- maintenance: User-facing maintenance tasks.
- dependencies: Upgrading (sometimes downgrading) dependencies.
- build: Internal-facing build tooling & test updates. Will not show up in release changelog.
- cleanup: Minor cleanup style change. Will not show up in release changelog.
- documentation: Documentation only changes. Will not show up in release changelog.
- feature request: Introducing a new feature.
- BREAKING CHANGE: Changes that break compatibility in some way with current major version.
- other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

github-actions · 2025-01-11T18:22:28Z

	Fails
🚫	PR is not labeled with one of: ["cleanup","BREAKING CHANGE","feature request","bug","documentation","maintenance","build","dependencies"]

Generated by 🚫 dangerJS against 1a15887

nx-cloud · 2025-01-11T18:33:59Z

View your CI Pipeline Execution ↗ for commit 1a15887.

Command	Status	Duration	Result
`nx run-many -t build --parallel=3`	✅ Succeeded	1m 37s	View ↗

☁️ Nx Cloud last updated this comment at 2025-01-12 16:03:27 UTC

storybook-pr-benchmarking · 2025-01-11T20:08:02Z

Package Benchmarks

^{Commit: 1a15887, ran on 12 January 2025 at 16:06:14 UTC}

The following packages have significant changes to their size or dependencies:

`@storybook/addon-a11y`

	Before	After	Difference
Dependency count	59	59	0
Self size	410 KB	228 KB	🎉 -183 KB 🎉
Dependency size	13.46 MB	13.46 MB	🎉 -30 B 🎉
Bundle Size Analyzer	Link	Link

`@storybook/addon-essentials`

	Before	After	Difference
Dependency count	36	36	0
Self size	17 KB	12 KB	🎉 -4 KB 🎉
Dependency size	13.83 MB	13.83 MB	🎉 -2 KB 🎉
Bundle Size Analyzer	Link	Link

`@storybook/addon-mdx-gfm`

	Before	After	Difference
Dependency count	69	69	0
Self size	4 KB	3 KB	🎉 -1 KB 🎉
Dependency size	2.41 MB	2.41 MB	0 B
Bundle Size Analyzer	Link	Link

`@storybook/experimental-addon-test`

	Before	After	Difference
Dependency count	60	60	0
Self size	761 KB	774 KB	🚨 +13 KB 🚨
Dependency size	14.15 MB	14.15 MB	🎉 -14 B 🎉
Bundle Size Analyzer	Link	Link

`@storybook/builder-webpack5`

	Before	After	Difference
Dependency count	237	237	0
Self size	80 KB	80 KB	🎉 -16 B 🎉
Dependency size	31.10 MB	44.80 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core`

	Before	After	Difference
Dependency count	53	53	0
Self size	19.08 MB	19.10 MB	🚨 +20 KB 🚨
Dependency size	14.43 MB	14.43 MB	0 B
Bundle Size Analyzer	Link	Link

`@storybook/angular`

	Before	After	Difference
Dependency count	264	264	0
Self size	362 KB	362 KB	🎉 -55 B 🎉
Dependency size	33.63 MB	47.32 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/ember`

	Before	After	Difference
Dependency count	256	256	0
Self size	22 KB	22 KB	🎉 -16 B 🎉
Dependency size	31.13 MB	44.83 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/html-webpack5`

	Before	After	Difference
Dependency count	247	247	0
Self size	6 KB	6 KB	🎉 -16 B 🎉
Dependency size	31.65 MB	45.35 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/nextjs`

	Before	After	Difference
Dependency count	592	592	0
Self size	472 KB	472 KB	🎉 -308 B 🎉
Dependency size	83.39 MB	97.08 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preact-webpack5`

	Before	After	Difference
Dependency count	245	245	0
Self size	6 KB	6 KB	🎉 -16 B 🎉
Dependency size	31.23 MB	44.92 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/react-webpack5`

	Before	After	Difference
Dependency count	323	323	0
Self size	6 KB	6 KB	🎉 -16 B 🎉
Dependency size	42.43 MB	56.13 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/server-webpack5`

	Before	After	Difference
Dependency count	255	255	0
Self size	14 KB	14 KB	🎉 -16 B 🎉
Dependency size	32.63 MB	46.33 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/svelte-webpack5`

	Before	After	Difference
Dependency count	310	310	0
Self size	6 KB	6 KB	🎉 -16 B 🎉
Dependency size	39.22 MB	52.91 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/vue3-webpack5`

	Before	After	Difference
Dependency count	495	495	0
Self size	6 KB	6 KB	🎉 -16 B 🎉
Dependency size	55.63 MB	69.32 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/web-components-webpack5`

	Before	After	Difference
Dependency count	245	245	0
Self size	5 KB	5 KB	🎉 -16 B 🎉
Dependency size	31.28 MB	44.97 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`storybook`

	Before	After	Difference
Dependency count	54	54	0
Self size	22 KB	22 KB	🎉 -16 B 🎉
Dependency size	33.51 MB	33.53 MB	🚨 +20 KB 🚨
Bundle Size Analyzer	Link	Link

`sb`

	Before	After	Difference
Dependency count	55	55	0
Self size	1 KB	1 KB	🎉 -10 B 🎉
Dependency size	33.53 MB	33.55 MB	🚨 +20 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/cli`

	Before	After	Difference
Dependency count	396	396	0
Self size	496 KB	494 KB	🎉 -2 KB 🎉
Dependency size	75.46 MB	75.48 MB	🚨 +18 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/codemod`

	Before	After	Difference
Dependency count	276	276	0
Self size	612 KB	612 KB	🎉 -21 B 🎉
Dependency size	65.36 MB	65.38 MB	🚨 +20 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/core-webpack`

	Before	After	Difference
Dependency count	1	1	0
Self size	16 KB	13.71 MB	🚨 +13.69 MB 🚨
Dependency size	28 KB	28 KB	0 B
Bundle Size Analyzer	Link	Link

`create-storybook`

	Before	After	Difference
Dependency count	112	112	0
Self size	1.11 MB	1.11 MB	🎉 -3 KB 🎉
Dependency size	42.64 MB	42.67 MB	🚨 +20 KB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-html-webpack`

	Before	After	Difference
Dependency count	102	102	0
Self size	4 KB	4 KB	🎉 -16 B 🎉
Dependency size	22.72 MB	36.41 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-preact-webpack`

	Before	After	Difference
Dependency count	2	2	0
Self size	5 KB	5 KB	🎉 -16 B 🎉
Dependency size	44 KB	13.74 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-react-webpack`

	Before	After	Difference
Dependency count	191	191	0
Self size	24 KB	24 KB	🎉 -31 B 🎉
Dependency size	33.52 MB	47.21 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-server-webpack`

	Before	After	Difference
Dependency count	18	18	0
Self size	10 KB	10 KB	🎉 -16 B 🎉
Dependency size	1.48 MB	15.17 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-svelte-webpack`

	Before	After	Difference
Dependency count	101	101	0
Self size	14 KB	14 KB	🎉 -16 B 🎉
Dependency size	10.40 MB	24.09 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

`@storybook/preset-vue3-webpack`

	Before	After	Difference
Dependency count	375	375	0
Self size	9 KB	9 KB	🎉 -16 B 🎉
Dependency size	47.62 MB	61.31 MB	🚨 +13.69 MB 🚨
Bundle Size Analyzer	Link	Link

ndelangen added 17 commits January 10, 2025 17:22

just moving some core around

1617cd1

install

a2f0a32

fix references to ../scripts

9c79233

adjust scripts paths

8edfc4c

adjust scripts paths

ac06f03

cleanup

fd8cb1f

working check in core

f6b8958

successful compile of core

b1a229e

working compile

cd778e1

linting config fixes

36160bd

fix linting config file

557433b

apply linting fixes

e518577

linting fixes

bf7c88f

fix markdown linting

35d38b5

cleanup

53be741

fix mocks paths

c19b85c

Merge branch 'next' into norbert/monorepo-unsplit

df79790

ndelangen requested review from kylegach and jonniebigodes as code owners January 11, 2025 18:20

ndelangen added the ci:normal label Jan 11, 2025

ndelangen self-assigned this Jan 11, 2025

ndelangen added 3 commits January 11, 2025 19:23

improve CI config

a62eed4

fix CI config

d54794c

fix lockfile

b84e002

ndelangen added 4 commits January 11, 2025 19:37

use --immutable

91a2c33

fixes

ba4f0f5

fix for CI config

ee883be

fix CI config

53ffc20

ndelangen added 4 commits January 11, 2025 20:29

somehow not available in CI, but is locally

d26420a

cleanup

46a4f51

fix verdaccio paths

1514a11

rename

6b31bde

ndelangen added 9 commits January 11, 2025 21:11

overhaul workspace restore

46326b2

fix paths in package.json

f8b352f

fix knip config file paths

a1dea9d

do not detect our monorepo as nx project

d19f5aa

dedupe typescript lib

355608e

fix problem with addon docs not getting detected by nx

21c6c19

disable catch-all story pattern in main.ts

74fab79

fix path

af32484

fix a few tests

1a15887

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Experiment: Monorepo refactor #30247

Experiment: Monorepo refactor #30247

ndelangen commented Jan 11, 2025

github-actions bot commented Jan 11, 2025 •

edited

Loading

nx-cloud bot commented Jan 11, 2025 •

edited

Loading

storybook-pr-benchmarking bot commented Jan 11, 2025 •

edited

Loading

Experiment: Monorepo refactor #30247

Are you sure you want to change the base?

Experiment: Monorepo refactor #30247

Conversation

ndelangen commented Jan 11, 2025

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

Manual testing

Documentation

Checklist for Maintainers

🦋 Canary release

github-actions bot commented Jan 11, 2025 • edited Loading

nx-cloud bot commented Jan 11, 2025 • edited Loading

storybook-pr-benchmarking bot commented Jan 11, 2025 • edited Loading

Package Benchmarks

@storybook/addon-a11y

@storybook/addon-essentials

@storybook/addon-mdx-gfm

@storybook/experimental-addon-test

@storybook/builder-webpack5

@storybook/core

@storybook/angular

@storybook/ember

@storybook/html-webpack5

@storybook/nextjs

@storybook/preact-webpack5

@storybook/react-webpack5

@storybook/server-webpack5

@storybook/svelte-webpack5

@storybook/vue3-webpack5

@storybook/web-components-webpack5

storybook

sb

@storybook/cli

@storybook/codemod

@storybook/core-webpack

create-storybook

@storybook/preset-html-webpack

@storybook/preset-preact-webpack

@storybook/preset-react-webpack

@storybook/preset-server-webpack

@storybook/preset-svelte-webpack

@storybook/preset-vue3-webpack

github-actions bot commented Jan 11, 2025 •

edited

Loading

nx-cloud bot commented Jan 11, 2025 •

edited

Loading

storybook-pr-benchmarking bot commented Jan 11, 2025 •

edited

Loading

`@storybook/addon-a11y`

`@storybook/addon-essentials`

`@storybook/addon-mdx-gfm`

`@storybook/experimental-addon-test`

`@storybook/builder-webpack5`

`@storybook/core`

`@storybook/angular`

`@storybook/ember`

`@storybook/html-webpack5`

`@storybook/nextjs`

`@storybook/preact-webpack5`

`@storybook/react-webpack5`

`@storybook/server-webpack5`

`@storybook/svelte-webpack5`

`@storybook/vue3-webpack5`

`@storybook/web-components-webpack5`

`storybook`

`sb`

`@storybook/cli`

`@storybook/codemod`

`@storybook/core-webpack`

`create-storybook`

`@storybook/preset-html-webpack`

`@storybook/preset-preact-webpack`

`@storybook/preset-react-webpack`

`@storybook/preset-server-webpack`

`@storybook/preset-svelte-webpack`

`@storybook/preset-vue3-webpack`