Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced CSS of Newsletter Section #653

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Enhanced CSS of Newsletter Section #653

wants to merge 2 commits into from

Conversation

Pranjal6955
Copy link

Description

This pull request enhances the design of the NewsShelter section, focusing on the email input field and subscribe button for a more modern, polished, and user-friendly experience.

Changes Made

Email Input Field

  • Rounded borders for a sleek look.
  • Subtle glow effect on focus for better interactivity.
  • Added required attribute for improved validation.

Subscribe Button

  • Smooth hover color transition for visual feedback.
  • Adjusted padding for better alignment.

Scoped Styles

  • Localized styles to avoid affecting global CSS.

Impact

  • Improved UX: Clean, interactive design that boosts user engagement.
  • Better Accessibility: Optimized for responsiveness across devices.
  • Easier Maintenance: Scoped styles for simpler updates.

Screenshots

  1. Before:
    Before

  2. After:
    After

@Pranjal6955 Pranjal6955 mentioned this pull request Jan 20, 2025
Closed
pikurasa
pikurasa requested changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@pikurasa pikurasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that you only have changes related to customizing the buttons; nothing else.

Also, any custom CSS should be confined to custom.css, not airspace.css as that is from upstream.

css/airspace.css
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not making custom changes to airspace.css

We only do that in custom.css

@Pranjal6955 Pranjal6955 requested a review from pikurasa January 22, 2025 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pikurasa pikurasa Awaiting requested review from pikurasa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pranjal6955 @pikurasa