fix(types): type instantiation is excessively deep and possibly infinite #597
+290
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using MergeDeep type-fest even with simple structures we get this error For typescript > 4.5.5 this trick fix the issue by forcing TS to infer the value And reuse it instead of computing multiple time
avallete
commented
Jan 20, 2025
src/PostgrestFilterBuilder.ts
Outdated
Comment on lines
76
to
80
| value: ResolveFilterValue<Schema, Row, ColumnName> extends infer ResolvedFilterValue | ||
| ? ResolvedFilterValue extends never | ||
| ? NonNullable<unknown> | ||
| : NonNullable<ResolvedFilterValue> | ||
| : never |
There was a problem hiding this comment.
The actual tricks is to use the infer and never to force typescript to infer the right type and not stop at "possibly infinite recursive".
avallete
changed the title
avallete
commented
Jan 20, 2025
Comment on lines
+276
to
+282
| values: ReadonlyArray< | ||
| ResolveFilterValue<Schema, Row, ColumnName> extends infer ResolvedFilterValue | ||
| ? ResolvedFilterValue extends never | ||
| ? unknown[] | ||
| : ResolvedFilterValue | ||
| : never | ||
| > |
There was a problem hiding this comment.
Here we need the infer within the ReadonlyArray to have the proper resulting type, otherwise we'll have an invalid union.
Comment on lines
+1834
to
+1836
| // @ts-expect-error should not be able to eq 'id' since the column does not | ||
| // exist | ||
| .eq('id', 2) |
There was a problem hiding this comment.
I think this test should never had passed because the query actually is made to return an error. And id column doesn't exist in users table.
We can make it pass tough by changing the never into an unknown here:
|
Not All Heroes Wear Capes 🫡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix a case on typescript > 4.5.5 where using
MergeDeepoverride lead to an error ofType instantiation is excessively deep and possibly infinite. Use a trick to "force typescript to infer final type" instead of doing a shallow inspection and warning about possible infinite recursion.This is a bit black magic'ish but it fix the issue on the reproduction case 😅
Additional context
Related: supabase/supabase-js#1354