fix: Remove replication slot teardown from disconnect (#1272)

supabase · Jan 21, 2025 · 5f1c769 · 5f1c769
1 parent 998967e
commit 5f1c769
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 7 deletions.
diff --git a/lib/realtime/tenants/replication_connection.ex b/lib/realtime/tenants/replication_connection.ex
@@ -339,11 +339,6 @@ defmodule Realtime.Tenants.ReplicationConnection do
 
   @impl true
   def handle_disconnect(state) do
-    %{tenant_id: tenant_id, replication_slot_name: replication_slot_name} = state
-
-    tenant = Cache.get_tenant_by_external_id(tenant_id)
-    Database.replication_slot_teardown(tenant, replication_slot_name)
-
     Logger.warning("Disconnecting broadcast changes handler: #{inspect(state, pretty: true)}")
     {:noreply, %{state | step: :disconnected}}
   end

diff --git a/mix.exs b/mix.exs
@@ -4,7 +4,7 @@ defmodule Realtime.MixProject do
   def project do
     [
       app: :realtime,
-      version: "2.34.0",
+      version: "2.34.1",
       elixir: "~> 1.17.3",
       elixirc_paths: elixirc_paths(Mix.env()),
       start_permanent: Mix.env() == :prod,

diff --git a/test/support/cleanup.ex b/test/support/cleanup.ex
@@ -16,7 +16,6 @@ defmodule Cleanup do
 
     # Stop lingering connections
     Enum.each(:ets.tab2list(@table_name), fn {tenant_id, _, _, _, _, _} ->
-      IO.inspect("Shutting down tenant: #{tenant_id}")
       Connect.shutdown(tenant_id)
     end)