Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Separate read and write authorization and add telemetry #1273

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

filipecabaco
Copy link
Member

What kind of change does this PR introduce?

  • Separates read and write flows for authorization to ensure we are able to only check writes when user tries to broadcast or track presence
  • Adds telemetry to Database.transaction so we can check latency of queries
  • Add latency on Authorization queries

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
realtime-demo ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 5:54pm

@filipecabaco filipecabaco force-pushed the fix/authorization-write-check-improvements branch from fd062be to eca8a57 Compare January 22, 2025 14:41
lib/realtime/database.ex Outdated Show resolved Hide resolved
lib/realtime/tenants/authorization.ex Outdated Show resolved Hide resolved
lib/realtime/tenants/authorization.ex Outdated Show resolved Hide resolved
@filipecabaco filipecabaco force-pushed the fix/authorization-write-check-improvements branch 2 times, most recently from 1da3911 to 68cc441 Compare January 22, 2025 15:43
@filipecabaco filipecabaco force-pushed the fix/authorization-write-check-improvements branch from eab1af6 to d3303b1 Compare January 22, 2025 17:53
* Separates read and write flows for authorization to ensure we are able to only check writes when user tries to broadcast or track presence
* Adds telemetry to Database.transaction so we can check latency of queries
* Add latency on Authorization queries
@filipecabaco filipecabaco force-pushed the fix/authorization-write-check-improvements branch from d3303b1 to de92adb Compare January 22, 2025 17:54
@filipecabaco filipecabaco merged commit ab2cbdb into main Jan 22, 2025
5 checks passed
@filipecabaco filipecabaco deleted the fix/authorization-write-check-improvements branch January 22, 2025 18:06
@kiwicopple
Copy link
Member

🎉 This PR is included in version 2.34.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants