-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Resumable uploads #294
base: main
Are you sure you want to change the base?
Conversation
Will this be merged anytime soon? Experiencing some problems with regular uploads from some instances and this has been suggested as a possible fix in a ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've finally gotten around to reviewing this and there are a few things I think we should change here.
- The API seems too verbose and requires too many steps to start uploading when compared to https://github.com/tus/tus-py-client or even https://github.com/tus/tus-js-client.
- I have tested this with local Supabase (and this will probably be the same with self-hosted) and the TUS implementation in these environments don't return an
upload-expires
header and this is not implemented in any of the other TUS clients I've looked at so we should probably not have this either - In the tests you are checking if a url is https, not sure if this is a requirement for uploads as local Supabase doesn't have TLS enabled by default
After having a chat with @grdsdev, I think this PR should be put on hold for now. It diverges from the other Supabase client libraries and we should probably wait for an API design to be agreed upon before including resumable uploads into the Python library itself. In the time being we can add example code to the docs https://supabase.com/docs/guides/storage/uploads/resumable-uploads?queryGroups=language&language=js where Resumable uploads is mentioned using one of the third party libraries available for TUS with Python. |
I've opened a PR with example code for |
What kind of change does this PR introduce?